From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933618AbbI2POA (ORCPT ); Tue, 29 Sep 2015 11:14:00 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:53907 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754915AbbI2PNm (ORCPT ); Tue, 29 Sep 2015 11:13:42 -0400 Date: Tue, 29 Sep 2015 16:13:20 +0100 From: Mark Brown To: "Andrew F. Davis" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Lee Jones , Linus Walleij , Alexandre Courbot , Samuel Ortiz , Liam Girdwood , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20150929151320.GT30445@sirena.org.uk> References: <1443106374-4126-1-git-send-email-afd@ti.com> <1443106374-4126-5-git-send-email-afd@ti.com> <20150925180533.GN30445@sirena.org.uk> <5605AA1C.3090905@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dBO7RQoQeylDOh0t" Content-Disposition: inline In-Reply-To: <5605AA1C.3090905@ti.com> X-Cookie: NOBODY EXPECTS THE SPANISH INQUISITION! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dBO7RQoQeylDOh0t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 25, 2015 at 03:10:04PM -0500, Andrew F. Davis wrote: > On 09/25/2015 01:05 PM, Mark Brown wrote: > >On Thu, Sep 24, 2015 at 09:52:53AM -0500, Andrew F. Davis wrote: > >>+ match = of_match_device(tps65912_regulator_of_match_table, &pdev->dev); > >>+ if (!match) > >>+ return -ENODEV; > >>+ template = match->data; > >>+ id = template->id; > >>+ init_data = of_get_regulator_init_data(&pdev->dev, pdev->dev.of_node, > >>+ ®ulators[id]); > >Don't open code this stuff, use the core DT matching in the > >regulator_desc instead. > I assume you are referring to your additions in a0c7b164ad11? If so I'm not Please don't refer to commits by ID only, include a human readable description of the commit for the benefit of any humans who might read your mail. > sure that will save me anything as my probe function is called with a DT > match already, so no searching is needed. You've not understood what that change is replacing, the code I'm quoting above is exactly that code. Check out some of the existing drivers using this API. > >Please also use subject lines mathcing the style for the subsystem. > I'm not sure I know what you mean? What is wrong with my subject line, it looks > like the others I've looked at? You are using "regulators:", the regulator API uses "regulator:" - this should be really clear if you do something like a git shortlog. --dBO7RQoQeylDOh0t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWCqqPAAoJECTWi3JdVIfQXyYH/jsAgXlhyWqBDDO74YxEDUrs GMql3c0AkUuqzocdOlY3Q4GL5k7AxblNcTPWGD/iMG1SoCuAukOUOaqjRcQpGfRa 4uz5E8NGa2i8m4L281hicghhT0Bhr7akuDJXh/IE/H6ua9tzi0Vcv7bCMyH+gc4G ypKSUAVllZTXE1EKBw7gZXz3JQJ6Zx/RxLy5HmupKbKJK2zqHp5gNQ7Wn5E6hHIT 7OWiajHR1lfVfpmboP5nl/58WVGrTiNgJ9bjK8smBUNBj2njt/Q64cEyJ3Khcs+L YtCmIg8f8EHln3TCpguic17VTRqPaF4W+zlqPcmKKYkHc/psFAAjVqRktRR8gbQ= =7DKR -----END PGP SIGNATURE----- --dBO7RQoQeylDOh0t--