From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935106AbbI2PgB (ORCPT ); Tue, 29 Sep 2015 11:36:01 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:44498 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933393AbbI2Pfr (ORCPT ); Tue, 29 Sep 2015 11:35:47 -0400 Date: Tue, 29 Sep 2015 17:29:51 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, oleg@redhat.com, umgwanakikbuti@gmail.com, tglx@linutronix.de Subject: Re: [RFC][PATCH 05/11] sched: Add preempt argument to __schedule() Message-ID: <20150929152951.GQ3816@twins.programming.kicks-ass.net> References: <20150929092825.540553633@infradead.org> <20150929093520.146533609@infradead.org> <20150929112839.41a634b0@gandalf.local.home> <20150929113026.6b77b5c4@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150929113026.6b77b5c4@gandalf.local.home> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 11:30:26AM -0400, Steven Rostedt wrote: > On Tue, 29 Sep 2015 11:28:39 -0400 > Steven Rostedt wrote: > > > On Tue, 29 Sep 2015 11:28:30 +0200 > > Peter Zijlstra wrote: > > > > > There is only a single PREEMPT_ACTIVE use in the regular __schedule() > > > path and that is to circumvent the task->state check. Since the code > > > setting PREEMPT_ACTIVE is the immediate caller of __schedule() we can > > > replace this with a function argument. > > > > > > Signed-off-by: Peter Zijlstra (Intel) > > > --- > > > > Reviewed-by: Steven Rostedt > > I just want to note that this scared me at first, because __schedule() > can be traced by the function tracer that can also do a See 11/11 :-)