From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934958AbbI2Pwk (ORCPT ); Tue, 29 Sep 2015 11:52:40 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:52037 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934856AbbI2PwX (ORCPT ); Tue, 29 Sep 2015 11:52:23 -0400 Date: Tue, 29 Sep 2015 17:46:27 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, oleg@redhat.com, umgwanakikbuti@gmail.com, tglx@linutronix.de Subject: Re: [RFC][PATCH 09/11] sched, x86: Kill saved_preempt_count Message-ID: <20150929154627.GR3816@twins.programming.kicks-ass.net> References: <20150929092825.540553633@infradead.org> <20150929093520.511427093@infradead.org> <20150929114404.56c3021a@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150929114404.56c3021a@gandalf.local.home> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 11:44:04AM -0400, Steven Rostedt wrote: > On Tue, 29 Sep 2015 11:28:34 +0200 > Peter Zijlstra wrote: > > > With the introduction of the context switch preempt_count invariant, > > and the demise of PREEMPT_ACTIVE, its pointless to save/restore the > > per-cpu preemption count, it must always be 2. > > > > Signed-off-by: Peter Zijlstra (Intel) > > Should we add a warn on someplace: > > WARN_ON_ONCE(preempt_count() != 2) See v2 12/11 :-)