From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935059AbbI2Qck (ORCPT ); Tue, 29 Sep 2015 12:32:40 -0400 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:42971 "EHLO e28smtp02.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932398AbbI2Qc3 (ORCPT ); Tue, 29 Sep 2015 12:32:29 -0400 X-Helo: d28dlp02.in.ibm.com X-MailFrom: naveen.n.rao@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Tue, 29 Sep 2015 22:01:36 +0530 From: "Naveen N. Rao" To: Jiri Olsa Cc: LKML , Arnaldo Carvalho de Melo , "mingo@redhat.com" , Stephane Eranian , Sukadev Bhattiprolu , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] perf record: Limit --intr-regs to platforms supporting PERF_REGS Message-ID: <20150929163136.GA24723@naverao1-tp.ibm.com> References: <1443096718-11926-1-git-send-email-naveen.n.rao@linux.vnet.ibm.com> <20150924125703.GA11857@krava.redhat.com> <20150924164554.GA11493@naverao1-tp.in.ibm.com> <20150929053617.GA1060@naverao1-tp.in.ibm.com> <20150929065335.GE18363@krava.redhat.com> <20150929080010.GB1060@naverao1-tp.in.ibm.com> <20150929104711.GE27383@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150929104711.GE27383@krava.redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15092916-0005-0000-0000-000007CB21F0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/09/29 12:47PM, Jiri Olsa wrote: > On Tue, Sep 29, 2015 at 01:30:10PM +0530, Naveen N. Rao wrote: > > SNIP > > > > > Suka has also posted a fix for this with a different approach [1]. Can > > > > you please ack/pull one of these versions? Building perf is broken on > > > > v4.3-rc due to this. > > > > > > I did not get any answer for additional comments I made to the patch > > > (couldnt get marc.info working, sending the patch again) > > > > Hi Jiri, > > I concur with the changes you proposed to my patch here (getting rid of > > the weak variant): > > http://article.gmane.org/gmane.linux.kernel/2046108 > > > > I am aware of the other approach you posted (and the one attached > > below). When I said "please ack/pull one of these versions", I meant one > > of: your version, Suka's and mine. > > I was hoping somebody could test it on ppc ;-) > > I think the last version (in my last email) that keeps the weak > variable is correct, let's wait for Arnaldo to sort this out I just tried it, but it fails. As Suka points out in his patch: "Adding perf_regs.o to util/Build unconditionally, exposes a redefinition error for 'perf_reg_value()' function (due to the static inline version in util/perf_regs.h). So use #ifdef HAVE_PERF_REGS_SUPPORT' around that function." - Naveen