From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751394AbbI2XhV (ORCPT ); Tue, 29 Sep 2015 19:37:21 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:46177 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbbI2XhR (ORCPT ); Tue, 29 Sep 2015 19:37:17 -0400 Date: Tue, 29 Sep 2015 16:37:16 -0700 From: Andrew Morton To: Ulrich Obergfell Cc: linux-kernel@vger.kernel.org, dzickus@redhat.com, atomlin@redhat.com Subject: Re: [PATCH 2/5] watchdog: move watchdog_disable_all_cpus() outside of ifdef Message-Id: <20150929163716.ceb15ecfa9235f2175c419d5@linux-foundation.org> In-Reply-To: <1443473052-3053-3-git-send-email-uobergfe@redhat.com> References: <1443473052-3053-1-git-send-email-uobergfe@redhat.com> <1443473052-3053-3-git-send-email-uobergfe@redhat.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Sep 2015 22:44:09 +0200 Ulrich Obergfell wrote: > It makes sense to place watchdog_{dis|enable}_all_cpus() outside of > the ifdef so that _both_ are available even if CONFIG_SYSCTL is not > defined. Not really. With CONFIG_SYSCTL=n this change will cause a compile warning and will bloat up vmlinux. I'll rewrite the changelog to : Move watchdog_disable_all_cpus() outside of the ifdef so that it is : available if CONFIG_SYSCTL is not defined. This is preparation for : "watchdog: implement error handling in update_watchdog_all_cpus() and : callers".