From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755379AbbI3JiR (ORCPT ); Wed, 30 Sep 2015 05:38:17 -0400 Received: from smtprelay0171.hostedemail.com ([216.40.44.171]:56301 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755340AbbI3JiN (ORCPT ); Wed, 30 Sep 2015 05:38:13 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3872:4605:5007:6119:6261:7875:7903:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: maid25_81c2df9758f3f X-Filterd-Recvd-Size: 1850 Date: Wed, 30 Sep 2015 05:38:10 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, oleg@redhat.com, umgwanakikbuti@gmail.com, tglx@linutronix.de Subject: Re: [PATCH v2 12/12] sched: Add preempt_count invariant check Message-ID: <20150930053810.52507d1b@gandalf.local.home> In-Reply-To: <20150930072304.760800554@infradead.org> References: <20150930071035.514587432@infradead.org> <20150930072304.760800554@infradead.org> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015 09:10:47 +0200 Peter Zijlstra wrote: > Ingo requested I keep my debug check for the preempt_count invariant. > > Requested-by: Ingo Molnar > Signed-off-by: Peter Zijlstra (Intel) > --- > kernel/sched/core.c | 4 ++++ > 1 file changed, 4 insertions(+) > > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -2514,6 +2514,10 @@ static struct rq *finish_task_switch(str > * > * Also, see FORK_PREEMPT_COUNT. > */ > + if (unlikely(WARN_ONCE(preempt_count() != 2*PREEMPT_DISABLE_OFFSET, Nuke the "unlikely" it's redundant with the WARN_ONCE(). -- Steve > + "corrupted preempt_count: %s/%d/0x%x\n", > + current->comm, current->pid, preempt_count()))) > + preempt_count_set(FORK_PREEMPT_COUNT); > > rq->prev_mm = NULL; > >