From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754462AbbI3Gxi (ORCPT ); Wed, 30 Sep 2015 02:53:38 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:37445 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754368AbbI3Gxd (ORCPT ); Wed, 30 Sep 2015 02:53:33 -0400 Date: Wed, 30 Sep 2015 08:56:26 +0200 From: Daniel Vetter To: "davej@codemonkey.org.uk" , Jani Nikula , "Lankhorst, Maarten" , "linux-kernel@vger.kernel.org" , "torvalds@linux-foundation.org" , "intel-gfx@lists.freedesktop.org" , "Roper, Matthew D" , "Vetter, Daniel" , "dri-devel@lists.freedesktop.org" , "jbarnes@virtuousgeek.org" , "airlied@linux.ie" , "Miramontes Caton, Jairo Daniel" Subject: Re: [regression] [git pull] drm for 4.3 Message-ID: <20150930065626.GT3383@phenom.ffwll.local> Mail-Followup-To: "davej@codemonkey.org.uk" , Jani Nikula , "Lankhorst, Maarten" , "linux-kernel@vger.kernel.org" , "torvalds@linux-foundation.org" , "intel-gfx@lists.freedesktop.org" , "Roper, Matthew D" , "Vetter, Daniel" , "dri-devel@lists.freedesktop.org" , "jbarnes@virtuousgeek.org" , "airlied@linux.ie" , "Miramontes Caton, Jairo Daniel" References: <20150907184559.GA18393@codemonkey.org.uk> <20150921184849.GA25222@codemonkey.org.uk> <56016D01.5010708@virtuousgeek.org> <20150922151355.GX3383@phenom.ffwll.local> <20150922161558.GB24128@intel.com> <20150923014909.GA18010@codemonkey.org.uk> <1443006475.22058.1.camel@intel.com> <20150924035108.GA19724@codemonkey.org.uk> <877fng54or.fsf@intel.com> <20150930010722.GA19042@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150930010722.GA19042@codemonkey.org.uk> X-Operating-System: Linux phenom 4.1.0-2-amd64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 09:07:22PM -0400, davej@codemonkey.org.uk wrote: > On Thu, Sep 24, 2015 at 04:26:28PM +0300, Jani Nikula wrote: > > On Thu, 24 Sep 2015, "davej@codemonkey.org.uk" wrote: > > > On Wed, Sep 23, 2015 at 11:07:56AM +0000, Lankhorst, Maarten wrote: > > > > Hey, > > > > > > > > Dave Jones schreef op di 22-09-2015 om 21:49 [-0400]: > > > > > On Tue, Sep 22, 2015 at 09:15:58AM -0700, Matt Roper wrote: > > > > > > On Tue, Sep 22, 2015 at 05:13:55PM +0200, Daniel Vetter wrote: > > > > > > > On Tue, Sep 22, 2015 at 08:00:17AM -0700, Jesse Barnes wrote: > > > > > > > > Cc'ing Maarten and Matt; I'm guessing this may be related to one of > > > > > > > > their recent patches. > > > > > > > > > > > > Sounds like this showed up before my recent work, but I think I might > > > > > > have seen similar problems while working on atomic watermarks; the > > > > > > issues I was seeing were because the initial hardware readout could > > > > > > leave primary->visible set to true even when the CRTC was off. My > > > > > > series (which is still under development) contains this patch to fix > > > > > > that: > > > > > > > > > > > > http://patchwork.freedesktop.org/patch/59564/ > > > > > > > > > > > > Does applying that help with the problems reported here? > > > > > > > > > > No difference at all for me. > > > > Looks like a (reopened) dup of 91952? > > > > > > > > Can you apply "[PATCH] drm/i915: Add primary plane to mask if it's > > > > visible", and get me the results? > > > > > > This doesn't apply on top of Linus' current tree. > > > If you let me know what it's dependant on, I'll do a build with > > > those patches tomorrow. > > > > It's now part of the drm-intel-fixes pull request [1], maybe it's > > easiest to pull that in? Just four commits on top of > > v4.3-rc2. Alternatively pick it up from our repo [2]. > > The warning on boot seems to be gone as of rc3, but I can now trigger this pretty easily.. http://patchwork.freedesktop.org/patch/60618/ Cheers, Daniel > > WARNING: CPU: 2 PID: 28911 at drivers/gpu/drm/drm_atomic.c:889 drm_atomic_get_property+0x244/0x2d0() > CPU: 2 PID: 28911 Comm: trinity-c313 Not tainted 4.3.0-rc3-think+ #14 > 0000000000000379 ffff8801a1377c88 ffffffff8e35d5ec 0000000000000000 > ffff8801a1377cc0 ffffffff8e07a862 ffff880500b392b8 ffff880500a13008 > ffff880500b39290 ffff8804fe3806d8 ffff88003fa45668 ffff8801a1377cd0 > Call Trace: > [] dump_stack+0x4e/0x82 > [] warn_slowpath_common+0x82/0xc0 > [] warn_slowpath_null+0x1a/0x20 > [] drm_atomic_get_property+0x244/0x2d0 > [] drm_object_property_get_value+0x6c/0x70 > [] dpms_show+0x2f/0x70 > [] dev_attr_show+0x20/0x50 > [] ? sysfs_file_ops+0x41/0x60 > [] sysfs_kf_seq_show+0xb7/0x110 > [] kernfs_seq_show+0x26/0x30 > [] seq_read+0xe6/0x430 > [] kernfs_fop_read+0x127/0x170 > [] ? mutex_lock_nested+0x26b/0x3f0 > [] __vfs_read+0x28/0xe0 > [] ? mutex_lock_nested+0x287/0x3f0 > [] ? __fdget_pos+0x49/0x50 > [] ? __fdget_pos+0x49/0x50 > [] vfs_read+0x86/0x130 > [] SyS_read+0x49/0xb0 > [] entry_SYSCALL_64_fastpath+0x12/0x6f > ---[ end trace e053063c697a1355 ]--- > > 887 case DRM_MODE_OBJECT_CONNECTOR: { > 888 struct drm_connector *connector = obj_to_connector(obj); > 889 WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex)); > 890 ret = drm_atomic_connector_get_property(connector, > 891 connector->state, property, val); > 892 break; > 893 } > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch