From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754652AbbI3ILT (ORCPT ); Wed, 30 Sep 2015 04:11:19 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:33347 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754607AbbI3ILD (ORCPT ); Wed, 30 Sep 2015 04:11:03 -0400 Date: Wed, 30 Sep 2015 08:48:25 +0100 From: Charles Keepax To: Jiada Wang CC: , , , , , , Subject: Re: [PATCH] ASoC: Codec: wm8962: balance pm_runtime_enable Message-ID: <20150930074825.GJ5432@ck-lbox> References: <1443588853-8778-1-git-send-email-jiada_wang@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1443588853-8778-1-git-send-email-jiada_wang@mentor.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-09-30_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1509300131 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2015 at 01:54:13PM +0900, Jiada Wang wrote: > pm_runtime_enable is called in probe to enable runtime PM > for wm8962 codec, but pm_runtime_disable isn't called in remove > callback, nor is called in error path if probe fails after runtime > PM is enabled, this causes unbalanced pm_runtime_enable. > > This patch Adds pm_runtime_disable in remove callback and error path, > to balance pm_runtime_enable. > > Signed-off-by: Jiada Wang > --- Acked-by: Charles Keepax Thanks, Charles