From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754130AbbI3IBi (ORCPT ); Wed, 30 Sep 2015 04:01:38 -0400 Received: from mga02.intel.com ([134.134.136.20]:18584 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753660AbbI3IBh (ORCPT ); Wed, 30 Sep 2015 04:01:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,611,1437462000"; d="scan'208";a="800292141" Date: Wed, 30 Sep 2015 13:30:28 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: fix balance of privatecnt Message-ID: <20150930080028.GF21690@vkoul-mobl.iind.intel.com> References: <1443085415-17957-1-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443085415-17957-1-git-send-email-peter.ujfalusi@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2015 at 12:03:35PM +0300, Peter Ujfalusi wrote: > dma_release_channel() decrements privatecnt counter and almost all dma_get* > function increments it with the exception of dma_get_slave_channel(). > In most cases this does not cause issue since normally the channel is not > requested and released, but if a driver requests DMA channel via > dma_get_slave_channel() and releases the channel the privatecnt will be > unbalanced and this will prevent for example getting channel for memcpy. Applied, thanks -- ~Vinod