From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754644AbbI3Iao (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Sep 2015 04:30:44 -0400
Received: from mail.fireflyinternet.com ([87.106.93.118]:63808 "EHLO
	fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1753846AbbI3Iaj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Sep 2015 04:30:39 -0400
X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138;
Date: Wed, 30 Sep 2015 09:30:27 +0100
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Robert Bragg <robert@sixbynine.org>
Cc: intel-gfx@lists.freedesktop.org, Daniel Vetter <daniel.vetter@intel.com>,
        Sourab Gupta <sourab.gupta@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        David Airlie <airlied@linux.ie>, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>, Kan Liang <kan.liang@intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Zheng Yan <zheng.z.yan@intel.com>, Mark Rutland <mark.rutland@arm.com>,
        Matt Fleming <matt.fleming@intel.com>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [RFC 0/6] Non perf based Gen Graphics OA unit driver
Message-ID: <20150930083027.GF9929@nuc-i3427.alporthouse.com>
Mail-Followup-To: Chris Wilson <chris@chris-wilson.co.uk>,
	Robert Bragg <robert@sixbynine.org>,
	intel-gfx@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	Sourab Gupta <sourab.gupta@intel.com>,
	Zhenyu Wang <zhenyuw@linux.intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	David Airlie <airlied@linux.ie>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>, Kan Liang <kan.liang@intel.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Zheng Yan <zheng.z.yan@intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Matt Fleming <matt.fleming@intel.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org
References: <1443537549-6905-1-git-send-email-robert@sixbynine.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1443537549-6905-1-git-send-email-robert@sixbynine.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 29, 2015 at 03:39:03PM +0100, Robert Bragg wrote:
> Updating Mesa and GPU Top to experiment with this was straightforward
> given the similarity to the perf interface.  The main difference is that
> it only supports forwarding metrics via read()s instead of an mmaped
> circular buffer. As mentioned above, I think that suits this well, and
> requires no additional copying of data. I think the userspace code has
> ended up being a little simpler too.

Did you try updating the existing perf based overlay?

> Overall the driver currently isn't much more code than with perf (~200
> lines).
> 
> Personally my gut feeling a.t.m, is that we should aim to move forward
> independent from perf.
> 
> I'd really appreciate some feedback from others on this though.
> 
> Daniel and Chris; although I think it made sense at the outset to try
> and use perf, in light of the above would you be open to a non-perf
> based driver for the OA unit?

No. I strongly dislike that they will be multiple incompatibile perf
interfaces and strongly like the coupling with other profiling that
comes with perf - i.e. we very much want to simultaneously sample CPU
and GPU workloads along with other devices, that information is much
more useful to me for the purposes of scheduling work and maximising
concurrency than optimising shaders.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre