From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Andy Lutomirski <luto@amacapital.net>,
Andrey Konovalov <andreyknvl@google.com>,
Kostya Serebryany <kcc@google.com>,
Alexander Potapenko <glider@google.com>,
kasan-dev <kasan-dev@googlegroups.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
x86@kernel.org, Dmitry Vyukov <dvyukov@google.com>,
Sasha Levin <sasha.levin@oracle.com>,
Wolfram Gloger <wmglo@dent.med.uni-muenchen.de>
Subject: Re: [patch 0/2] x86/process: Sanitize bound checks in get_wchan() and unify 32/64 bit
Date: Wed, 30 Sep 2015 11:06:20 +0200 [thread overview]
Message-ID: <20150930090620.GC6033@pd.tnic> (raw)
In-Reply-To: <20150930082754.401022511@linutronix.de>
On Wed, Sep 30, 2015 at 08:38:21AM -0000, Thomas Gleixner wrote:
> As reported by several people the bound checks in get_wchan() on x86/64bit
> are wrong.
>
> The following series addresses that problem and as a consequence
> unifies the needlessly different implementations of 32 and 64 bit.
>
> Thanks,
>
> tglx
>
> ---
> process.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> process_32.c | 28 ----------------------------
> process_64.c | 24 ------------------------
> 3 files changed, 55 insertions(+), 52 deletions(-)
Hohumm, looks good to me. Especially the documentation of the stack
layout and why we're doing all that dance.
Reviewed-by: Borislav Petkov <bp@suse.de>
Should we CC: stable?
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2015-09-30 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 8:38 Thomas Gleixner
2015-09-30 8:38 ` [patch 1/2] x86/process: Add proper bound checks in 64bit get_wchan() Thomas Gleixner
2015-09-30 19:54 ` [tip:x86/urgent] " tip-bot for Thomas Gleixner
2015-10-03 1:15 ` [patch 1/2] " Sasha Levin
2015-10-03 1:31 ` Andy Lutomirski
2015-10-03 10:54 ` Thomas Gleixner
2015-10-03 11:31 ` Andrey Ryabinin
2015-10-04 12:14 ` Dmitry Vyukov
[not found] ` <CAN=P9ph=u4YqxtK7iA3R12E86DVYBdZos+Yv0n6cw7E-ZU8x_g@mail.gmail.com>
2015-10-04 18:04 ` Dmitry Vyukov
2015-09-30 8:38 ` [patch 2/2] x86/process: Unify 32bit and 64bit implementations of get_wchan() Thomas Gleixner
2015-09-30 19:54 ` [tip:x86/urgent] " tip-bot for Thomas Gleixner
2015-09-30 9:06 ` Borislav Petkov [this message]
2015-09-30 9:13 ` [patch 0/2] x86/process: Sanitize bound checks in get_wchan() and unify 32/64 bit Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930090620.GC6033@pd.tnic \
--to=bp@alien8.de \
--cc=ak@linux.intel.com \
--cc=andreyknvl@google.com \
--cc=dvlasenk@redhat.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=ryabinin.a.a@gmail.com \
--cc=sasha.levin@oracle.com \
--cc=tglx@linutronix.de \
--cc=wmglo@dent.med.uni-muenchen.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome