From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755184AbbI3Heh (ORCPT ); Wed, 30 Sep 2015 03:34:37 -0400 Received: from down.free-electrons.com ([37.187.137.238]:38251 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755119AbbI3HeS convert rfc822-to-8bit (ORCPT ); Wed, 30 Sep 2015 03:34:18 -0400 Date: Wed, 30 Sep 2015 09:33:55 +0200 From: Boris Brezillon To: "Bean Huo =?UTF-8?B?6ZyN5paM5paM?= (beanhuo)" Cc: Richard Weinberger , "dedekind1@gmail.com" , "adrian.hunter@intel.com" , "computersforpeace@gmail.com" , "baruch@tkos.co.il" , "asierra@xes-inc.com" , "guz.fnst@cn.fujitsu.com" , "gsi@denx.de" , David Woodhouse , "linux-mtd@lists.infradead.org" , "Frank Liu =?UTF-8?B?5YiY576k?= (frankliu)" , Andrea Scian , "Karl Zhang =?UTF-8?B?5byg5Y+M6ZSj?= (karlzhang)" , Iwo Mergler , "Jeff Lauruhn (jlauruhn)" , Stefan Roese , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/9] drivers:mtd:UBI: add bakvol module for MLC NAND paired page issue Message-ID: <20150930093355.3266a4b3@bbrezillon> In-Reply-To: References: <560A59B8.4000701@nod.at> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015 05:31:43 +0000 Bean Huo 霍斌斌 (beanhuo) wrote: > > Am 28.09.2015 um 09:02 schrieb Bean Huo 霍斌斌 (beanhuo): > > > Hello, > > > > > > This series aims at adding a bakvol module for MLC NAND paired page > > > Power loss protection. > > > MLC NAND paired page power loss is a known issue so far, MLC NAND > > > pages are coupled in a sense that if you cut power while writing to a > > > page, you corrupt not only this page, but also one of the previous pages > > which is paired with the current one. > > > Currently, there is no a perfect solution for this. > > > This paired page solution is based on NAND multiple plane program > > > feature. For this Patch, only used dual plane page program, means two > > > different plane pages can Be programmed together at the same time. > > > Dual plane page program only implements in backup operation. Only > > > lower page data Be duplicated and back up into a internal log volume by > > dual plane program method. > > > > > > This patch has been testing on Micron 70s/80s/90s MLC NAND. > > > Of course there are some places needed to be improved and simplified. > > > > > > Any suggestion and comments welcomed. > > > > As stated before, using OOB in UBI is not going to happen unless proven that > > there is absolutely no other way to solve the paired pages problem. > > > > Nacked-by: Richard Weinberger > > > > Sorry, > > //Richard > > Hi, Richard > Thanks for your concern. I am a new patch submitter. > Can you tell me Nacked-by means? > > By the way, Do you review my patches series ? I don't backup duplicated data in OOB . That's not what Richard said, he just pointed that you were using the OOB area, and you're actually using it to store the information about which page you're backuping. > Can you specify which sector codes ? so that I can explain it in detail. And as answered by Richard, check_original_data() and mtd_write_dual_plane_oob() are filling the OOB buf with the original page offset, so you're definitely using the OOB area to store metadata. -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com