From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756158AbbI3Ng2 (ORCPT ); Wed, 30 Sep 2015 09:36:28 -0400 Received: from smtprelay0082.hostedemail.com ([216.40.44.82]:45104 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756021AbbI3NgY (ORCPT ); Wed, 30 Sep 2015 09:36:24 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3873:3874:4605:5007:6261:7875:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: mint10_1a94f97f7d71b X-Filterd-Recvd-Size: 2027 Date: Wed, 30 Sep 2015 09:36:21 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, oleg@redhat.com, umgwanakikbuti@gmail.com, tglx@linutronix.de Subject: Re: [PATCH v2 03/12] sched: Create preempt_count invariant Message-ID: <20150930093621.53b9f34c@gandalf.local.home> In-Reply-To: <20150930111323.GB2903@worktop.programming.kicks-ass.net> References: <20150930071035.514587432@infradead.org> <20150930072303.844400616@infradead.org> <20150930053208.0604317b@gandalf.local.home> <20150930111323.GB2903@worktop.programming.kicks-ass.net> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015 13:13:23 +0200 Peter Zijlstra wrote: > On Wed, Sep 30, 2015 at 05:32:08AM -0400, Steven Rostedt wrote: > > On Wed, 30 Sep 2015 09:10:38 +0200 > > Peter Zijlstra wrote: > > > -#ifdef CONFIG_PREEMPT_COUNT > > > -#define PREEMPT_DISABLED (1 + PREEMPT_ENABLED) > > > -#else > > > -#define PREEMPT_DISABLED PREEMPT_ENABLED > > > -#endif > > > +#define PREEMPT_DISABLED (PREEMPT_DISABLE_OFFSET + PREEMPT_ENABLED) > > > > Hmm, it looks to me that you removed all users of PREEMPT_DISABLED. > > > > Did you add another user of it? > > Dunno, lemme go grep ;-) > > include/linux/sched.h:#define PREEMPT_DISABLED (PREEMPT_DISABLE_OFFSET + PREEMPT_ENABLED) > kernel/sched/core.c: preempt_count_set(PREEMPT_DISABLED); > > So there still is one user. Ah, that's the one you added in patch 7. I did a git grep from the vanilla tree. -- Steve