From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753609AbbI3OcT (ORCPT ); Wed, 30 Sep 2015 10:32:19 -0400 Received: from mail-yk0-f170.google.com ([209.85.160.170]:33121 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752652AbbI3OcR (ORCPT ); Wed, 30 Sep 2015 10:32:17 -0400 Date: Wed, 30 Sep 2015 11:32:13 -0300 From: Gustavo Padovan To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, Greg Kroah-Hartman , Seung-Woo Kim , linux-kernel@vger.kernel.org, Kyungmin Park Subject: Re: [PATCH 1/2] component: Make a "match_add all devices matching my drivers" helper. Message-ID: <20150930143213.GB21618@joana> Mail-Followup-To: Gustavo Padovan , Eric Anholt , dri-devel@lists.freedesktop.org, Greg Kroah-Hartman , Seung-Woo Kim , linux-kernel@vger.kernel.org, Kyungmin Park References: <1443484449-31868-1-git-send-email-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443484449-31868-1-git-send-email-eric@anholt.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Eric, 2015-09-28 Eric Anholt : > The body of the loop is taken from the exynos driver. It appears to > also be useful in msm, and I've used it in vc4. > > Signed-off-by: Eric Anholt > --- > > This is separated from converting exynos to use it, to let it land > separately and not have to sync between trees. > > drivers/base/component.c | 40 ++++++++++++++++++++++++++++++++++++++++ > include/linux/component.h | 5 +++++ > 2 files changed, 45 insertions(+) This looks good to me. Reviewed-by: Gustavo Padovan Gustavo