From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754177AbbI3Q0b (ORCPT ); Wed, 30 Sep 2015 12:26:31 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:32771 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752610AbbI3Q03 (ORCPT ); Wed, 30 Sep 2015 12:26:29 -0400 Date: Wed, 30 Sep 2015 21:56:23 +0530 From: Sudip Mukherjee To: Brian Norris Cc: David Woodhouse , Dongsheng Yang , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, lkp@intel.com Subject: Re: [PATCH v2] mtd: mtdram: fix build error Message-ID: <20150930162623.GB21569@sudip-pc> References: <1443619766-8134-1-git-send-email-sudipm.mukherjee@gmail.com> <20150930155107.GA5192@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150930155107.GA5192@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2015 at 08:51:07AM -0700, Brian Norris wrote: > On Wed, Sep 30, 2015 at 06:59:26PM +0530, Sudip Mukherjee wrote: > > i386 allmodconfig fails with: > > ERROR: "__umoddi3" [drivers/mtd/devices/mtdram.ko] undefined! > > ERROR: "__moddi3" [drivers/mtd/devices/mtdram.ko] undefined! > > > > arm allmodconfig fails with: > > ERROR: "__aeabi_uldivmod" [drivers/mtd/devices/mtdram.ko] undefined! > > ERROR: "__aeabi_ldivmod" [drivers/mtd/devices/mtdram.ko] undefined! > > > > mips allmodconfig fails with: > > ERROR: "__umoddi3" [drivers/mtd/devices/mtdram.ko] undefined! > > ERROR: "__moddi3" [drivers/mtd/devices/mtdram.ko] undefined! > > > > The modulus operation is not being supported by these compilers. Use > > do_div() instead which returns the remainder. > > > > Fixes: 7827e3acad2d ("mtd: mtdram: check offs and len in mtdram->erase") > > Signed-off-by: Sudip Mukherjee > > --- > > > > v1 showed build warning with cris and xtensa. I have checked v2 with > > arm, cris and xtensa. > > I already reverted the bad patch, so this doesn't apply any more... > > If you want to send a squashed patch that redoes this properly, I can > take it. Ok. Sending the new patch. regards sudip