From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shli@fb.com>
Cc: linux-kernel@vger.kernel.org, Kernel-team@fb.com
Subject: Re: [PATCH] workqueue: make sure delayed work run in local cpu
Date: Wed, 30 Sep 2015 13:13:20 -0400 [thread overview]
Message-ID: <20150930171320.GE2627@mtj.duckdns.org> (raw)
In-Reply-To: <d78da48d87042b738d62e8f7a10e426f0cc87581.1443570021.git.shli@fb.com>
On Wed, Sep 30, 2015 at 09:05:30AM -0700, Shaohua Li wrote:
> My system keeps crash with below message. vmstat_update() schedules a delayed
> work in current cpu and expects the work runs in the cpu.
> schedule_delayed_work() is expected to make delayed work run in local cpu. The
> problem is timer can be migrated with NO_HZ. __queue_work() queues work in
> timer handler, which could run in a different cpu other than where the delayed
> work is scheduled. The end result is the delayed work runs in different cpu.
> The patch makes __queue_delayed_work records local cpu earlier. Where the timer
> runs doesn't change where the work runs with the change.
>
...
> Signed-off-by: Shaohua Li <shli@fb.com>
This has been broken since 09. No idea why it wasn't triggering
before. Maybe the timer wasn't actually being migrated?
Applied to wq/for-4.3-fixes w/ stable tag added.
Thanks.
--
tejun
prev parent reply other threads:[~2015-09-30 17:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 16:05 Shaohua Li
2015-09-30 17:13 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930171320.GE2627@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=Kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®