From: Mark Brown <broonie@kernel.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regmap: debugfs: improve regmap_reg_ranges_read_file()
Date: Wed, 30 Sep 2015 18:18:52 +0100 [thread overview]
Message-ID: <20150930171852.GD15635@sirena.org.uk> (raw)
In-Reply-To: <878u7okzfe.fsf@rasmusvillemoes.dk>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On Wed, Sep 30, 2015 at 11:51:33AM +0200, Rasmus Villemoes wrote:
> On Tue, Sep 29 2015, Mark Brown <broonie@kernel.org> wrote:
> > On Tue, Sep 29, 2015 at 12:29:02AM +0200, Rasmus Villemoes wrote:
> > That said I think memcpy() is going to be the best way of getting to
> > that since one of the issues there (which currently doesn't work) is
> > slicing things off the front and memcpy() handles that nicely.
> I'm not sure I understand what you want to do. Should I resend as three
> separate patches (the four bullets minus the PAGE_SIZE thing), and then
> we can take it from there?
I'd like to while we're at optimising the code to make it more
functional by supporting copying out any chunk of data rather than just
complete lines as now.
In any case, please split up and resend as you suggest above.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-09-30 17:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 22:29 [PATCH 1/2] regmap: debugfs: remove bogus check Rasmus Villemoes
2015-09-28 22:29 ` [PATCH 2/2] regmap: debugfs: improve regmap_reg_ranges_read_file() Rasmus Villemoes
2015-09-29 18:30 ` Mark Brown
2015-09-30 9:51 ` Rasmus Villemoes
2015-09-30 17:18 ` Mark Brown [this message]
2015-09-30 18:30 ` [PATCH v2 1/3] regmap: debugfs: use snprintf return value in regmap_reg_ranges_read_file() Rasmus Villemoes
2015-09-30 18:30 ` [PATCH v2 2/3] regmap: debugfs: use memcpy instead of snprintf Rasmus Villemoes
2015-09-30 18:30 ` [PATCH v2 3/3] regmap: debugfs: simplify regmap_reg_ranges_read_file() slightly Rasmus Villemoes
2015-09-29 18:14 ` [PATCH 1/2] regmap: debugfs: remove bogus check Mark Brown
2015-09-30 7:27 ` Rasmus Villemoes
2015-09-30 17:20 ` Mark Brown
2015-09-30 17:52 ` Rasmus Villemoes
2015-09-30 18:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930171852.GD15635@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome