From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932583AbbI3Rji (ORCPT ); Wed, 30 Sep 2015 13:39:38 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59093 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932456AbbI3Rje (ORCPT ); Wed, 30 Sep 2015 13:39:34 -0400 Date: Wed, 30 Sep 2015 18:39:21 +0100 From: Mark Brown To: Fei Wang Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, khilman@linaro.org, sameo@linux.intel.com, lee.jones@linaro.org, lgirdwood@gmail.com, bintian.wang@huawei.com, xuwei5@hisilicon.com, haojian.zhuang@linaro.org, zhangfei.gao@linaro.org, guodong.xu@linaro.org, jorge.ramirez-ortiz@linaro.org, puck.chen@hisilicon.com, xuyiping@hisilicon.com, kong.kongxinwei@hisilicon.com, z.liuxinliang@hisilicon.com, william.wfei@gmail.com, zhongkaihua@huawei.com Message-ID: <20150930173921.GJ15635@sirena.org.uk> References: <1443611111-3196-1-git-send-email-w.f@huawei.com> <1443611111-3196-2-git-send-email-w.f@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HkMjoL2LAeBLhbFV" Content-Disposition: inline In-Reply-To: <1443611111-3196-2-git-send-email-w.f@huawei.com> X-Cookie: Give him an evasive answer. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2a01:348:6:8808:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/8] dt-bindings: pmic: Document Hi655x pmic driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HkMjoL2LAeBLhbFV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 30, 2015 at 07:05:04PM +0800, Fei Wang wrote: > +Hisilicon hi655x Power Management Integrated Circuit (PMIC) > + > +hi655x consists of a large and varied group of sub-devices: > + > +Device Supply Names Description > +------ ------------ ----------- > +hi655x-powerkey : : Powerkey > +hi655x-regulator-pmic : : Regulators > +hi655x-usbvbus : : USB plug detection > +hi655x-pmu-rtc : : RTC > +hi655x-coul : : Coulomb ...counter? There's no documentation of the bindings for any of the above devices or how things are structured, you need to provide binding documentation which is understandable standalone. None of the properties are documented, nor is the set of regulators supported or how this is structured. > + coul: coul@1 { > + compatible = "hisilicon,hi655x-coul"; > + interrupt-parent = <&pmic>; > + interrupts = <24 0>, <25 0>, <26 0>, <27 0>; > + interrupt-names = "cl_int_i", "cl_out_i", "cl_in_i", "vbat_int_i"; > + battery_product_index = <0>; For example, the "battery_product_index" property here is undocumented. --HkMjoL2LAeBLhbFV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWDB5IAAoJECTWi3JdVIfQuO0H/0M/kWh41VA1rb1m+7boZOEw 3pfopLMbJR57H/9HQCqA/LFlei88/uY9omUgZwL0D4QI1PY4GJiifI9rvi+L7DRP aIadlfBo3bz3WURWK4iZ1w5ipQwYJsLtxLDfETRZeeG0mVAnqx0A1YY+0caTlVGi Yo3qXDbnVdDB4NyZWt65Iq4b7ULgdTQviDa3zU43kAlnjK9hSCOgg9k2j+1V5qOm nlWqbKblnCpyjZ0OsBev0ubp8lRySBFkKC08gkgekNuqHkixPGv3TrIULwOQJAy9 LgexOUFXZ4JCLSutCZdNId55n8GNv0e5AMMnLO7UKRqGifGForBUF0XtzYZmRXU= =Fgaz -----END PGP SIGNATURE----- --HkMjoL2LAeBLhbFV--