From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932783AbbI3SCZ (ORCPT ); Wed, 30 Sep 2015 14:02:25 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59188 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932260AbbI3SCW (ORCPT ); Wed, 30 Sep 2015 14:02:22 -0400 Date: Wed, 30 Sep 2015 19:02:13 +0100 From: Mark Brown To: Sascha Hauer Cc: linux-kernel@vger.kernel.org, Liam Girdwood , kernel@pengutronix.de, alkml@pengutronix.de Message-ID: <20150930180213.GL15635@sirena.org.uk> References: <1443621474-2191-1-git-send-email-s.hauer@pengutronix.de> <1443621474-2191-2-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RVlUGXxwBj5SDcM9" Content-Disposition: inline In-Reply-To: <1443621474-2191-2-git-send-email-s.hauer@pengutronix.de> X-Cookie: Give him an evasive answer. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2a01:348:6:8808:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/6] Revert "regulator: core: Handle full constraints systems when resolving supplies" X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --RVlUGXxwBj5SDcM9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 30, 2015 at 03:57:49PM +0200, Sascha Hauer wrote: > This reverts commit 9f7e25edb1575a6d2363dc003f9cc09d840657e2. >=20 > When a regulator A is registered and is supplied by regulator B which is > not yet registered then a regulator_get on regulator A will set the As > supply to the dummy regulator. This is not correct, we should return > -EPROBE_DEFER instead as done without this patch. What makes you say this is not correct? In a system with fully specified supplies if we fail to resolve the supply we know that no supply will ever appear and so substitute in the dummy on the assumption that there is a supply with no software control. --RVlUGXxwBj5SDcM9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWDCOkAAoJECTWi3JdVIfQ9LkH/3/LL9+q7VkcB5xB4I/s8Vri N1kYJy3zsk3eb1QBbVm9B0feSPSAMcqhPgAU2eGXcnUMh4QAAkC6WKeMfqKL1DpH Mo2BWVxNA6C3owjhS5hl4EKZ5yBdYss0b6Bj9mAOtsIGopZgxf7DN/mNtplbRgB6 jpCaY56KsFspg0CpZyks3EAJswylzuWfb1ywUcZW2hf80wXYEVfxujm++UA/360L gA9GxoQvfJeCmqlSqpJfBS/mzqDQ4e6t8P5Fdl5xrSl/zfU+0UfmvTyJPLidg2yj brwktCRLiHI5Ev6IYB3EDrfuCqqZTyurPkVYHb5HvAkRLemRxS5wbaV2Tyolbj0= =Ftkp -----END PGP SIGNATURE----- --RVlUGXxwBj5SDcM9--