From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932794AbbI3TJP (ORCPT ); Wed, 30 Sep 2015 15:09:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35943 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754360AbbI3TJN (ORCPT ); Wed, 30 Sep 2015 15:09:13 -0400 Date: Wed, 30 Sep 2015 21:09:09 +0200 From: Jiri Olsa To: Sukadev Bhattiprolu Cc: Arnaldo Carvalho de Melo , eranian@google.com, naveen.n.rao@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks Message-ID: <20150930190909.GA27570@krava.redhat.com> References: <20150930182836.GA27858@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150930182836.GA27858@us.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2015 at 11:28:36AM -0700, Sukadev Bhattiprolu wrote: > From e29aeeee7236122c4d807ec9ebc721b5d7d75c8d Mon Sep 17 00:00:00 2001 > From: Sukadev Bhattiprolu > Date: Thu, 24 Sep 2015 17:53:49 -0400 > Subject: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks > > perf_regs.c does not get built on Powerpc as CONFIG_PERF_REGS is false. > So the weak definition for 'sample_regs_masks' doesn't get picked up. > > Adding perf_regs.o to util/Build unconditionally, exposes a redefinition > error for 'perf_reg_value()' function (due to the static inline version > in util/perf_regs.h). So use #ifdef HAVE_PERF_REGS_SUPPORT' around that > function. > > Signed-off-by: Sukadev Bhattiprolu Acked-by: Jiri Olsa thanks, jirka