From: Mark Brown <broonie@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
kernel@pengutronix.de, alkml@pengutronix.de
Subject: Re: [PATCH 1/6] Revert "regulator: core: Handle full constraints systems when resolving supplies"
Date: Wed, 30 Sep 2015 20:26:13 +0100 [thread overview]
Message-ID: <20150930192613.GA15635@sirena.org.uk> (raw)
In-Reply-To: <20150930184812.GE7858@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Wed, Sep 30, 2015 at 08:48:12PM +0200, Sascha Hauer wrote:
> During boot the fsl,imx6q-gpc is probed and tries to get its regulator.
> fsl,anatop-regulator is already registered, the dlg,da9063 is not. The
> call to regulator_get tries to resolve the supply using
> regulator_resolve_supply. regulator_resolve_supply then calls
> regulator_dev_lookup which returns NULL because the supply (vddsoc_reg)
> is specified in the device tree but not yet present. &ret is correctly
> filled with -EPROBE_DEFER in this case, but this is ignored. Instead due
> to 9f7e25edb157 the dummy regulator is used. This case worked before
> 9f7e25edb157.
Ah, I see - yes that's a bug. Untested patch incoming, let me know if
that works.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-09-30 19:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 13:57 [RFC] regulator: Propagate voltage changes to supply regulators Sascha Hauer
2015-09-30 13:57 ` [PATCH 1/6] Revert "regulator: core: Handle full constraints systems when resolving supplies" Sascha Hauer
2015-09-30 18:02 ` Mark Brown
2015-09-30 18:48 ` Sascha Hauer
2015-09-30 19:26 ` Mark Brown [this message]
2015-09-30 13:57 ` [PATCH 2/6] regulator: core: introduce function to lock regulators and its supplies Sascha Hauer
2015-09-30 13:57 ` [PATCH 3/6] regulator: core: create unlocked version of regulator_list_voltage Sascha Hauer
2015-09-30 13:57 ` [PATCH 4/6] regulator: core: Propagate voltage changes to supply regulators Sascha Hauer
2015-09-30 13:57 ` [PATCH 5/6] regulator: i.MX anatop: Allow supply regulator Sascha Hauer
2015-09-30 13:57 ` [PATCH 6/6] ARM: i.MX6 Phytec PFLA02: Add supplies for the SoC internal regulators Sascha Hauer
2015-09-30 14:07 ` [RFC] regulator: Propagate voltage changes to supply regulators Sascha Hauer
2015-09-30 14:05 Sascha Hauer
2015-09-30 14:05 ` [PATCH 1/6] Revert "regulator: core: Handle full constraints systems when resolving supplies" Sascha Hauer
2015-09-30 18:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930192613.GA15635@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alkml@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®