From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754784AbbI3WgQ (ORCPT ); Wed, 30 Sep 2015 18:36:16 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60246 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753280AbbI3WgO (ORCPT ); Wed, 30 Sep 2015 18:36:14 -0400 Date: Wed, 30 Sep 2015 23:36:03 +0100 From: Mark Brown To: Sascha Hauer Cc: linux-kernel@vger.kernel.org, Liam Girdwood , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Message-ID: <20150930223603.GF15635@sirena.org.uk> References: <1443621946-8712-1-git-send-email-s.hauer@pengutronix.de> <1443621946-8712-4-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p//XFgTqeVWI1epd" Content-Disposition: inline In-Reply-To: <1443621946-8712-4-git-send-email-s.hauer@pengutronix.de> X-Cookie: Give him an evasive answer. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2a01:348:6:8808:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/6] regulator: core: create unlocked version of regulator_list_voltage X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --p//XFgTqeVWI1epd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 30, 2015 at 04:05:43PM +0200, Sascha Hauer wrote: > The unlocked version will be needed when we start propagating voltage > changes to the supply regulators. I'm now wondering why we have a locked _list_voltage() in the first place... it *should* be a pure function that doesn't need any locking. I'll check tomorrow if there are any users who care but if there aren't the change here is probably to remove the locking entirely. --p//XFgTqeVWI1epd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWDGPTAAoJECTWi3JdVIfQuoAH/iS32ugIvJ1tCWTK0lfQDcjg zErhtlI162FVHN5p6i4r6FMmMBSqrxBKWoY3H0fFxK05mCbFB5dMWfd3gz4AUDrr eIM7loL77v7fEftake6Y4E1Gkt4o+fdRSXTPxCI6QSkWjfJ0iFGHG0tGzWfDDIFP 5IVa3/YgfmX9DFQ/NfSmxRNY6n8tCdIrJM+EK+rSGliJ3cSgyTgSB9YfvcJE+i6h +mGb3EtTsE2m2JZX17ev2f09PCNPKX78enTX8EU/zS8BM8VenizUMpZdg/poNf8V /zpcte40NDT4a7E3I8mP1qTqfk6CxZ2rDnfTEdGQLIdP0XaGDdfSDOsQlKtn/0s= =Ggk3 -----END PGP SIGNATURE----- --p//XFgTqeVWI1epd--