From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933625AbbJANEZ (ORCPT ); Thu, 1 Oct 2015 09:04:25 -0400 Received: from smtprelay0074.hostedemail.com ([216.40.44.74]:60320 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932966AbbJANEW (ORCPT ); Thu, 1 Oct 2015 09:04:22 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3870:3871:3872:3874:4362:4385:5007:6261:7875:7974:10004:10400:10848:10967:11026:11232:11658:11914:12050:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: apple83_602283bf6a940 X-Filterd-Recvd-Size: 1559 Date: Thu, 1 Oct 2015 09:04:19 -0400 From: Steven Rostedt To: Rasmus Villemoes Cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: use kstrdup_const instead of private implementation Message-ID: <20151001090419.5c5bf9b8@gandalf.local.home> In-Reply-To: <874mibg0cb.fsf@rasmusvillemoes.dk> References: <1441833841-12955-1-git-send-email-linux@rasmusvillemoes.dk> <874mibg0cb.fsf@rasmusvillemoes.dk> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015 21:43:00 +0200 Rasmus Villemoes wrote: > On Wed, Sep 09 2015, Rasmus Villemoes wrote: > > ping Thanks for the reminder. I'll take a look at your patches today. -- Steve > > > The kernel now has kstrdup_const/kfree_const for reusing .rodata > > (typically string literals) when possible; there's no reason to > > duplicate that logic in the tracing system. Moreover, as the comment > > above core_kernel_data states, it may not always return true for > > .rodata - that is for example the case on x86_64, where we thus end up > > kstrdup'ing all the passed-in strings. > >