From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756929AbbJAMtv (ORCPT ); Thu, 1 Oct 2015 08:49:51 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:38538 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755430AbbJAMtp (ORCPT ); Thu, 1 Oct 2015 08:49:45 -0400 Date: Thu, 1 Oct 2015 14:49:42 +0200 From: Michal Hocko To: Oleg Nesterov Cc: Andrew Morton , David Rientjes , Kyle Walker , Stanislav Kozina , Tetsuo Handa , linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm v2 1/3] mm/oom_kill: remove the wrong fatal_signal_pending() check in oom_kill_process() Message-ID: <20151001124941.GC24077@dhcp22.suse.cz> References: <20150930182341.GA15047@redhat.com> <20150930182405.GA15238@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150930182405.GA15238@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 30-09-15 20:24:05, Oleg Nesterov wrote: [...] > It is possible that the group leader > has the pending SIGKILL because its sub-thread originated the coredump, > in this case we must not skip this process. I do not understand this. If the group leader has SIGKILL pending it will die anyway regardless whether we send another sigkill or not, no? Or is the issue that another SIGKILL will wake it up? -- Michal Hocko SUSE Labs