From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Jiang Liu <jiang.liu@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: CPU hotplug and chained interrupts on x86
Date: Fri, 2 Oct 2015 07:58:39 +0300 [thread overview]
Message-ID: <20151002045839.GR1551@lahna.fi.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1510012343370.4500@nanos>
On Thu, Oct 01, 2015 at 11:45:23PM +0200, Thomas Gleixner wrote:
> On Thu, 1 Oct 2015, Thomas Gleixner wrote:
> > On Thu, 1 Oct 2015, Mika Westerberg wrote:
> > > Now if I plug/unplug the card I may get few interrupts to CPU0 but rest
> > > of the interrupts never happen. Probably because IO-APIC forwards them
> > > to the lowest priority CPU which is offline at this point.
> > >
> > > There is following check in fixup_irqs():
> > >
> > > if (!irq_has_action(irq) || irqd_is_per_cpu(data) ||
> > > cpumask_subset(affinity, cpu_online_mask)) {
> > > raw_spin_unlock(&desc->lock);
> > > continue;
> > > }
> > >
> > > If an interrupt is requested by a driver it will force new affinity and
> > > everything works fine. However if the interrupt is chained (it does not
> > > have ->action) this is skipped and the current affinity remains.
> > >
> > > We could detect here if the interrupt is chained but there seems to be
> > > no easy way to determine it currently so we would need to add a new flag
> > > to desc->status_use_accessors that gets set in __irq_do_set_handler()
> > > when is_chained is 1.
> >
> > Either there or in irq_data. Need to look at it in detail.
>
> desc->status_use_accessors is the place where this wants to go.
Thank you.
I'll prepare a patch fixing this shortly.
prev parent reply other threads:[~2015-10-02 4:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 14:21 Mika Westerberg
2015-10-01 14:31 ` Thomas Gleixner
2015-10-01 17:07 ` Jiang Liu
2015-10-01 21:45 ` Thomas Gleixner
2015-10-02 4:58 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002045839.GR1551@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®