mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: zhouchengming1@huawei.com, ard.biesheuvel@linaro.org,
	dingtianhong@huawei.com, will.deacon@arm.com,
	linux-kernel@vger.kernel.org, rostedt@goodmis.org,
	lizefan@huawei.com, Li Bin <huawei.libin@huawei.com>,
	guohanjun@huawei.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: ftrace: fix function_graph tracer panic
Date: Fri, 2 Oct 2015 13:42:41 +0100	[thread overview]
Message-ID: <20151002124240.GK6963@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <560E38C0.7080409@linaro.org>

On Fri, Oct 02, 2015 at 04:56:48PM +0900, AKASHI Takahiro wrote:
> >>On 09/30/2015 11:49 AM, Li Bin wrote:
> >>>This is because when using function graph tracer, if the traced
> >>>function return value is in multi regs ([0x-07]), return_to_handler
> 
> typo: 0x-07 => x0-x7

I fixed this up.

> and pre/post-indexed addressing stp&ldp may save add&sub instructions, but
> it's a matter of preference.

Doing it this way is more efficient in general as it avoids updating the
sp and writing in reverse order. That's the reason we recently changed
the kernel_entry/exit macros (see commit 63648dd20fa0 "arm64: entry:
use ldp/stp instead of push/pop when saving/restoring regs").

Thanks.

-- 
Catalin

      reply	other threads:[~2015-10-02 12:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30  2:49 Li Bin
2015-10-01  6:11 ` AKASHI Takahiro
2015-10-01 15:27   ` Catalin Marinas
2015-10-02  7:56     ` AKASHI Takahiro
2015-10-02 12:42       ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151002124240.GK6963@e104818-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=dingtianhong@huawei.com \
    --cc=guohanjun@huawei.com \
    --cc=huawei.libin@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=rostedt@goodmis.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=will.deacon@arm.com \
    --cc=zhouchengming1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®