From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbbJBOYw (ORCPT ); Fri, 2 Oct 2015 10:24:52 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:37945 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbbJBOYv (ORCPT ); Fri, 2 Oct 2015 10:24:51 -0400 Date: Fri, 2 Oct 2015 16:24:48 +0200 From: Michal Hocko To: Oleg Nesterov Cc: Tetsuo Handa , akpm@linux-foundation.org, rientjes@google.com, kwalker@redhat.com, skozina@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm v2 1/3] mm/oom_kill: remove the wrong fatal_signal_pending() check in oom_kill_process() Message-ID: <20151002142448.GC16302@dhcp22.suse.cz> References: <20151001154115.GA10342@redhat.com> <20151001161916.GK24077@dhcp22.suse.cz> <20151001175319.GA16313@redhat.com> <201510022032.IFC65105.JFtMOQOVSHFLOF@I-love.SAKURA.ne.jp> <20151002121142.GD2927@dhcp22.suse.cz> <201510022133.IJB87676.OOOHFFMtVFSQJL@I-love.SAKURA.ne.jp> <20151002133244.GA16302@dhcp22.suse.cz> <20151002135756.GB28533@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151002135756.GB28533@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 02-10-15 15:57:56, Oleg Nesterov wrote: > On 10/02, Michal Hocko wrote: > > > > So clone without CLONE_THREAD should create a new thread group leader > > and so create a new thread group. > > Yes. > > > Unless there is some other trickery > > which I do not see right now for_each_thread from the parent task > > shouldn't see those which are cloned without CLONE_THREAD. > > Yes. > > But I still do not understand what are you talking about, sorry ;) yes this whole thing was off-topic and I am sorry to add more confusion to it. > So let me say just in case that coredump (namely zap_threads()) will > also kill other thread groups with the same ->mm. Yes, I wanted to make sure to clarify what the thread_group is supposed to mean here but I only made it more confusing now that I am reading the whole thing again. Sorry about that. Calling processes which only share the mm as threads is confusing and only obscures the discussion. -- Michal Hocko SUSE Labs