From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753859AbbJBRh4 (ORCPT ); Fri, 2 Oct 2015 13:37:56 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:37497 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753483AbbJBRhw (ORCPT ); Fri, 2 Oct 2015 13:37:52 -0400 Date: Fri, 2 Oct 2015 12:37:47 -0500 From: Felipe Balbi To: Peter Senna Tschudin CC: , , , , , , , Subject: Re: [PATCH 13/14] RFC: usb/host/faraday-hcd: Move #defines outside struct Message-ID: <20151002173747.GX5552@saruman.tx.rr.com> Reply-To: References: <20150915165002.GP19948@saruman.tx.rr.com> <1442847678-7970-1-git-send-email-peter.senna@gmail.com> <1442847678-7970-14-git-send-email-peter.senna@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uWCTLymdFNG0vGYZ" Content-Disposition: inline In-Reply-To: <1442847678-7970-14-git-send-email-peter.senna@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uWCTLymdFNG0vGYZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2015 at 05:01:17PM +0200, Peter Senna Tschudin wrote: > For making the code more readable and to facilitate supporting multiple > hardware versions, move #defines to outside the struct declaration. This > patch also renames fhcd2xx_regs to fotg210_regs as this struct is > specific to fotg210. >=20 > Signed-off-by: Peter Senna Tschudin > --- > drivers/usb/host/faraday-hcd.h | 137 ++++++++++++++++++++++-------------= ------ > 1 file changed, 74 insertions(+), 63 deletions(-) >=20 > diff --git a/drivers/usb/host/faraday-hcd.h b/drivers/usb/host/faraday-hc= d.h > index cf29edf..f75c467 100644 > --- a/drivers/usb/host/faraday-hcd.h > +++ b/drivers/usb/host/faraday-hcd.h > @@ -85,7 +85,7 @@ struct fhcd2xx_hcd { /* one per controller */ > =20 > /* glue to PCI and HCD framework */ > struct fhcd2xx_caps __iomem *caps; > - struct fhcd2xx_regs __iomem *regs; > + struct fotg210_regs __iomem *regs; should this be in previous patch ? personally, I don't see what's the benefit of this patch, however not again= st it either. --=20 balbi --uWCTLymdFNG0vGYZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWDsDrAAoJEIaOsuA1yqREUk8P/jRIPc8KUoN8ZHhuUAiF2PPD SFkMjkj46FrqvCNELQ3kv6+cVMQChN9kjCRIJZ3AxTfkCxhzorDzlra5cxF1TD0H EknXQPUyaWrMWhp28STGZFETlzOjIofZHC4PPaYZ4oXGyRteBCWe6xWssXlEuJ+y Wr9fV4iphFieoWG5Ir7+GWqj2qosjRk1fzRAeECg7sTKreMTYanmKDcIw+NLlBxv LzEx1efbqsJY31YT6Zdg24SBRFVysiNLMGoDTqNpuCyr3KXPQeeoxXkdjZ1SAe+p PYW2a8qNYH1DO19GPI+SoTJnLMNa8gEZ/xHX9t2GMJOzxbfi9qehiCzWH3VYhN0l Ei+j6P4QFZzClCaP9dZHnNA86GzQH2q2iu64+oks3ao8urOoP+88VmGN2wf34fWS YYt+i8Q8+td+B/5Z4ILUo5bVieYkebfsgJR1ScpFtaGV5DSBYrxk9EYy4pannwv9 pYqghcWY5kI3Wo8850wQQiF0KjjqKi3fMKy3STK5H/BSDd2Fj8NLzPIjT09p+8xq 2f42JNSZH19tXkQgtevOvdb0eSPkT9FZW0ER/p/YkaMpEJRx37aYKmDUOizf8tKW OfgczIKmPu651iJ2rEZdKtYJzeqzY6+8paReghnXJxYmn1OkfZbIjyhnsk2f9Rdz p329jxQ6ORhdJPZdnRVT =JE1s -----END PGP SIGNATURE----- --uWCTLymdFNG0vGYZ--