From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751074AbbJCVrt (ORCPT ); Sat, 3 Oct 2015 17:47:49 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:48297 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbbJCVrr (ORCPT ); Sat, 3 Oct 2015 17:47:47 -0400 Date: Sat, 3 Oct 2015 23:47:08 +0200 From: Francois Romieu To: Andrej Cc: linux-kernel@vger.kernel.org, davem@davemloft.net Subject: Re: via-rhine: fix VLAN receive handling error in 4.2.x Message-ID: <20151003214708.GA32210@electric-eye.fr.zoreil.com> References: <20151003172155.77A8AF404@mta2.toshio.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151003172155.77A8AF404@mta2.toshio.eu> X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrej : [...] > Choosing between changing rhine_get_vlan_tci(), which retrieves TCI from > skb->data, or moving eth_type_trans() invocation after rhine_rx_vlan_tag(), > I chose the latter. Can you send a patch with a proper Signed-off-by and a single line 'Fixes: 810f19bcb862 ("via-rhine: add consistent memory barrier in vlan receive code.")' or do you want me to do that ? The patch ought to be based against davem's net but it wouldn't make any noticeable difference. -- Ueimor