From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751437AbbJDGZd (ORCPT ); Sun, 4 Oct 2015 02:25:33 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:36037 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbbJDGZb (ORCPT ); Sun, 4 Oct 2015 02:25:31 -0400 Date: Sat, 3 Oct 2015 23:25:29 -0700 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Alexander Viro , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 4/7] xattr handlers: Pass handler to operations instead of flags Message-ID: <20151004062529.GC28519@infradead.org> References: <1442924812-9384-1-git-send-email-agruenba@redhat.com> <1442924812-9384-5-git-send-email-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442924812-9384-5-git-send-email-agruenba@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2015 at 02:26:49PM +0200, Andreas Gruenbacher wrote: > The xattr_handler operations are currently all passed a file system > specific flags value which the operations can use to disambiguate between > different handlers; some file systems use that to distinguish the xattr > namespace, for example. In some oprations, it would be useful to also have > access to the handler prefix. To allow that, pass a pointer to the handler > to operations instead of the flags value alone. > > Signed-off-by: Andreas Gruenbacher Looks good, Reviewed-by: Christoph Hellwig