From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751446AbbJDG1N (ORCPT ); Sun, 4 Oct 2015 02:27:13 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:36439 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbbJDG1L (ORCPT ); Sun, 4 Oct 2015 02:27:11 -0400 Date: Sat, 3 Oct 2015 23:27:09 -0700 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Alexander Viro , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , v9fs-developer@lists.sourceforge.net Subject: Re: [PATCH v2 5/7] 9p: xattr simplifications Message-ID: <20151004062709.GD28519@infradead.org> References: <1442924812-9384-1-git-send-email-agruenba@redhat.com> <1442924812-9384-6-git-send-email-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442924812-9384-6-git-send-email-agruenba@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2015 at 02:26:50PM +0200, Andreas Gruenbacher wrote: > > +/** > + * xattr_full_name - Compute full attribute name from suffix > + * Missing argument descriptions for a kdoc comment. > +const char *xattr_full_name(const struct xattr_handler *handler, > + const char *name) > +{ > + size_t prefix_len = strlen(handler->prefix); > + > + /* assert(memcmp(name - prefix_len, handler->prefix, prefix_len) == 0); */ This either should be a real WARN_ON or go away.