From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751504AbbJDItr (ORCPT ); Sun, 4 Oct 2015 04:49:47 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39557 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbbJDItp (ORCPT ); Sun, 4 Oct 2015 04:49:45 -0400 Date: Sun, 4 Oct 2015 09:49:40 +0100 From: Greg KH To: mike dupuis Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null() Message-ID: <20151004084940.GB30827@kroah.com> References: <1443906596-2956-1-git-send-email-mike.dupuis.0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443906596-2956-1-git-send-email-mike.dupuis.0@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 03, 2015 at 01:09:56PM -0800, mike dupuis wrote: > This is a patch to remove the function ieee80211_ccmp_null(). > This function does nothing and can therefore be safely removed. > > Signed-off-by: Mike Dupuis > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c > index 61edd57..af22ee5 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c > @@ -175,9 +175,6 @@ struct net_device *alloc_ieee80211(int sizeof_priv) > ieee->last_packet_time[i] = 0; > } > > -/* These function were added to load crypte module autoly */ > - ieee80211_ccmp_null(); > - You didn't remove the function, only the call to it. And I think you just broke the "autoload" logic that these "call a null function" function calls were trying to solve, which isn't good at all. Have you verified that everything correctly auto-loads when the device is plugged into the system? thanks, greg k-h