From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751726AbbJDNNl (ORCPT ); Sun, 4 Oct 2015 09:13:41 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:60283 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbbJDNNj (ORCPT ); Sun, 4 Oct 2015 09:13:39 -0400 Date: Sun, 4 Oct 2015 13:51:55 +0100 From: Charles Keepax To: Chanwoo Choi CC: , , , , , , , , Subject: Re: [PATCH] extcon: Modify the id and name of external connector Message-ID: <20151004125155.GB21528@ck-lbox> References: <1443930336-25422-1-git-send-email-cw00.choi@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1443930336-25422-1-git-send-email-cw00.choi@samsung.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-04_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1510040231 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 04, 2015 at 12:45:36PM +0900, Chanwoo Choi wrote: > This patch modifies the id and name of external connector with the additional > prefix to clarify both attribute and meaning of external connector as following: > - EXTCON_CHG_* mean the charger connector. > - EXTCON_JACK_* mean the jack connector. > - EXTCON_DISP_* mean the display port connector. > > Following table show the new name of external connector with old name: > ------------------------------------------------- > Old extcon name | New extcon name | > ------------------------------------------------- > EXTCON_TA | EXTCON_CHG_USB_DCP | > EXTCON_FAST_CHARGER | EXTCON_CHG_USB_FAST | > EXTCON_SLOW_CHARGER | EXTCON_CHG_USB_SLOW | > EXTCON_CHARGE_DOWNSTREAM| EXTCON_CHG_USB_CDP | > ------------------------------------------------- > EXTCON_MICROPHONE | EXTCON_JACK_MICROPHONE| > EXTCON_HEADPHONE | EXTCON_JACK_HEADPHONE | > EXTCON_LINE_IN | EXTCON_JACK_LINE_IN | > EXTCON_LINE_OUT | EXTCON_JACK_LINE_OUT | > EXTCON_VIDEO_IN | EXTCON_JACK_VIDEO_IN | > EXTCON_VIDEO_OUT | EXTCON_JACK_VIDEO_OUT | > EXTCON_SPDIF_IN | EXTCON_JACK_SPDIF_IN | > EXTCON_SPDIF_OUT | EXTCON_JACK_SPDIF_OUT | > ------------------------------------------------- > EXTCON_HMDI | EXTCON_DISP_HDMI | > EXTCON_MHL | EXTCON_DISP_MHL | > EXTCON_DVI | EXTCON_DISP_DVI | > EXTCON_VGA | EXTCON_DISP_VGA | > ------------------------------------------------- > > And, when altering the name of USB charger connector, EXTCON refers to the > "USB battery charging specification"[1] to use the standard name of USB > charging port as following. Following name of USB charging port are already used > in power_supply subsystem. We chan check it on patch[2]. > - EXTCON_CHG_USB /* Standard Downstream Port */ > - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */ > - EXTCON_CHG_USB_CDP /* Charging Downstream Port */ > - EXTCON_CHG_USB_ACA /* Accessory Charging Adapter */ > > [1] http://www.usb.org/developers/docs/devclass_docs/USB_Battery_Charging_1.2.pdf > [2] commit 85efc8a18ce ("[PATCH] power_supply: Add types for USB chargers") > > Signed-off-by: Chanwoo Choi > --- For the Arizona changes: Acked-by: Charles Keepax Thanks, Charles