From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbbJDTnT (ORCPT ); Sun, 4 Oct 2015 15:43:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56871 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbbJDTnS (ORCPT ); Sun, 4 Oct 2015 15:43:18 -0400 Date: Sun, 4 Oct 2015 20:43:13 +0100 From: Greg KH To: Mike Dupuis Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null() Message-ID: <20151004194313.GB23542@kroah.com> References: <1443906596-2956-1-git-send-email-mike.dupuis.0@gmail.com> <20151004084940.GB30827@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 04, 2015 at 10:46:05AM -0800, Mike Dupuis wrote: > > And I think you just broke the "autoload" logic that these "call a null > > function" function calls were trying to solve, which isn't good at all. > > I guess this bit is lost on me-- how does calling a function from a > previously unused object affect the state of a driver or kernel module? It forces the module where that function is to be loaded into memory before this function can be called. That is if we have multiple modules here, I haven't looked at the code in a long time to verify it, but note, you are totally ignoring the comment put there in the code that says this. greg k-h