From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752847AbbJEKQQ (ORCPT ); Mon, 5 Oct 2015 06:16:16 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38852 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbbJEKQP (ORCPT ); Mon, 5 Oct 2015 06:16:15 -0400 Date: Mon, 05 Oct 2015 03:31:55 -0700 (PDT) Message-Id: <20151005.033155.2121849340240343993.davem@davemloft.net> To: linux@davidrobins.net Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: usb: asix: Fix crash on skb alloc failure From: David Miller In-Reply-To: <1443644404-6452-1-git-send-email-linux@davidrobins.net> References: <1443644404-6452-1-git-send-email-linux@davidrobins.net> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Oct 2015 03:16:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "David B. Robins" Date: Wed, 30 Sep 2015 16:20:04 -0400 > If asix_rx_fixup_internal() fails to allocate rx->ax_skb, it will return > but not clear rx->size. rx points to driver private data. A later call > assumes that nonzero size means ax_skb was allocated and passes a null > ax_skb to skb_put. Changed allocation failure return to clear size first. > > Found testing board with AX88772B devices. > > Signed-off-by: David B. Robins Applied, thanks.