From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753067AbbJEKpF (ORCPT ); Mon, 5 Oct 2015 06:45:05 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:39136 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753002AbbJEKpD (ORCPT ); Mon, 5 Oct 2015 06:45:03 -0400 Date: Mon, 05 Oct 2015 04:00:42 -0700 (PDT) Message-Id: <20151005.040042.705688813405698539.davem@davemloft.net> To: jon@ringle.org Cc: broonie@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jringle@gridpoint.com Subject: Re: [PATCH net-next v2 2/2] net: Microchip encx24j600 driver From: David Miller In-Reply-To: <20151005.035455.1570277826736853837.davem@davemloft.net> References: <1443699801-8888-1-git-send-email-jon@ringle.org> <1443699801-8888-2-git-send-email-jon@ringle.org> <20151005.035455.1570277826736853837.davem@davemloft.net> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Oct 2015 03:45:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t95AjBvE006262 From: David Miller Date: Mon, 05 Oct 2015 03:54:55 -0700 (PDT) > From: jon@ringle.org > Date: Thu, 1 Oct 2015 07:43:21 -0400 > >> From: Jon Ringle >> >> This ethernet driver supports the Micorchip enc424j600/626j600 Ethernet >> controller over a SPI bus interface. This driver makes use of the regmap API to >> optimize access to registers by caching registers where possible. >> >> Datasheet: >> http://ww1.microchip.com/downloads/en/DeviceDoc/39935b.pdf >> >> Signed-off-by: Jon Ringle > > Applied. Actually, I had to revert both patches. Please look at the compiler warnings your code generates: drivers/mfd/wm5110-tables.c: In function ¡wm5110_patch¢: drivers/mfd/wm5110-tables.c:281:11: warning: passing argument 2 of ¡regmap_register_patch¢ from incompatible pointer type [enabled by default] In file included from include/linux/mfd/arizona/core.h:17:0, from drivers/mfd/wm5110-tables.c:15: include/linux/regmap.h:727:5: note: expected ¡const struct reg_sequence *¢ but argument is of type ¡const struct reg_default *¢ drivers/mfd/wm8998-tables.c: In function ¡wm8998_patch¢: drivers/mfd/wm8998-tables.c:50:10: warning: passing argument 2 of ¡regmap_register_patch¢ from incompatible pointer type [enabled by default] In file included from include/linux/mfd/arizona/core.h:17:0, from drivers/mfd/wm8998-tables.c:15: include/linux/regmap.h:727:5: note: expected ¡const struct reg_sequence *¢ but argument is of type ¡const struct reg_default *¢ ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayºʇڙë,j­¢f£¢·hšïêÿ‘êçz_è®(­éšŽŠÝ¢j"ú¶m§ÿÿ¾«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^¶m§ÿÿà ÿ¶ìÿ¢¸?–I¥