From: Vinod Koul <vinod.koul@intel.com>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
Cc: dan.j.williams@intel.com, michal.simek@xilinx.com,
soren.brinkmann@xilinx.com, moritz.fischer@ettus.com,
appanad@xilinx.com, anirudha@xilinx.com,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9] dmaengine: Add Xilinx AXI Direct Memory Access Engine driver support
Date: Mon, 5 Oct 2015 16:26:30 +0100 [thread overview]
Message-ID: <20151005152628.GE13501@vkoul-mobl.iind.intel.com> (raw)
In-Reply-To: <1440432666-10310-1-git-send-email-appanad@xilinx.com>
On Mon, Aug 24, 2015 at 09:41:06PM +0530, Kedareswara rao Appana wrote:
> This is the driver for the AXI Direct Memory Access (AXI DMA)
> core, which is a soft Xilinx IP core that provides high-
> bandwidth direct memory access between memory and AXI4-Stream
> type target peripherals.
Okay reviewing this after the other Xilinx driver with very similar name, I
am very concerned about code duplication. Both codes seems to be pretty much
copy paste and some modifications for IP. In Linux kernel we reuse!
Please create common lib for Xilinx drivers to use and
have HW diff is two drivers, or manage those with different driver ops
Pls justify why we should have two drivers. Looking at code makes me think
otherwise
--
~Vinod
next prev parent reply other threads:[~2015-10-05 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 16:11 Kedareswara rao Appana
2015-08-27 14:30 ` Moritz Fischer
2015-08-28 6:31 ` Michal Simek
2015-09-21 17:17 ` Moritz Fischer
2015-10-05 13:01 ` Appana Durga Kedareswara Rao
2015-10-05 15:26 ` Vinod Koul [this message]
2015-10-05 15:48 ` Appana Durga Kedareswara Rao
2015-10-06 7:45 ` Vinod Koul
2015-11-10 10:23 ` Appana Durga Kedareswara Rao
2015-11-11 10:55 ` Vinod Koul
2015-11-11 12:22 ` Appana Durga Kedareswara Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005152628.GE13501@vkoul-mobl.iind.intel.com \
--to=vinod.koul@intel.com \
--cc=anirudha@xilinx.com \
--cc=appana.durga.rao@xilinx.com \
--cc=appanad@xilinx.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=moritz.fischer@ettus.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®