From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752678AbbJEP40 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 5 Oct 2015 11:56:26 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45351 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750979AbbJEP4Y (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 5 Oct 2015 11:56:24 -0400
Date: Mon, 5 Oct 2015 16:55:43 +0100
From: Mark Brown <broonie@kernel.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Support Opensource <support.opensource@diasemi.com>
Message-ID: <20151005155543.GY12635@sirena.org.uk>
References: <cover.1444042230.git.Adam.Thomson.Opensource@diasemi.com>
 <8b10191f4e14b32f831d32c66c7edebd861b70ac.1444042230.git.Adam.Thomson.Opensource@diasemi.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="TrSyUYpaPvvX07X2"
Content-Disposition: inline
In-Reply-To: <8b10191f4e14b32f831d32c66c7edebd861b70ac.1444042230.git.Adam.Thomson.Opensource@diasemi.com>
X-Cookie: Walk softly and carry a megawatt laser.
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: 89.101.192.72
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH 1/2] ASoC: da7213: Add DT support to codec driver
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--TrSyUYpaPvvX07X2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Oct 05, 2015 at 04:40:18PM +0100, Adam Thomson wrote:

> This patch adds support for DT bindings in the codec driver.
> As part of this support, the mclk data can now be provided and
> used to control the mclk during codec operation.

Please split out the new MCLK configuration into a separate patch which
describes what that configuration is, it's much easier to review that
way.  Otherwise there's a couple of minor issues here but nothing too
critical.

>  	case SND_SOC_BIAS_STANDBY:
>  		if (snd_soc_codec_get_bias_level(codec) == SND_SOC_BIAS_OFF) {
> +			/* MCLK */
> +			clk_prepare_enable(da7213->mclk);
> +

This doesn't check the return value.

>  	.driver = {
>  		.name = "da7213",
> +		.of_match_table = da7213_of_match,

Please use of_match_ptr() here.

--TrSyUYpaPvvX07X2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWEp17AAoJECTWi3JdVIfQzekH/RfMew2zcn2SOlEXmB6NFgDH
5DXcdrGPttjG92cTWzS2czA9Q523Vyqq+GKR0WG/x720w832fF17y8b6jCyhsoN9
mg3Run+44NwNvhD6RRI9O4OlB9p0KIK4l71wVIbxoijjESXOLck5tFPwjSs6BV4G
UKWmtCIz94s3qzhR1M4F0gU8MTSMDVQ0oK/EDNiBuhaiQL6ZXXDR2Mg3fnoxJu0v
XJ8An7F3/HTGrmpdXfcfmz10RIumS/WomZK8ubQGEThHu1NFxhD0x0ebYaDA7MTr
n9skQFzWatRRH7rOQpiIXllYRld2xLPGy08KWWD6G7tsymUt6ycjfaVS9EE9OSw=
=WuPO
-----END PGP SIGNATURE-----

--TrSyUYpaPvvX07X2--