From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbbJERoe (ORCPT ); Mon, 5 Oct 2015 13:44:34 -0400 Received: from mail-yk0-f170.google.com ([209.85.160.170]:35766 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708AbbJERoa (ORCPT ); Mon, 5 Oct 2015 13:44:30 -0400 Date: Mon, 5 Oct 2015 13:44:26 -0400 From: Tejun Heo To: Lee Duncan Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, James Bottomley , Hannes Reinecke , Johannes Thumshirn , Christoph Hellwig , Greg Kroah-Hartman , Matthew Wilcox , linux-nvme@lists.infradead.org, Joshua Morris , Philip Kelleher Subject: Re: [PATCH 0/5] Modify ida_* users to use ida_simple_* Message-ID: <20151005174426.GB11164@htj.duckdns.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 01, 2015 at 11:59:04AM -0700, Lee Duncan wrote: > The ida index management routines are used in several > driver modules to manage allocation and release of > index values. Reviewing the way in which the > ida routines were called, together with the small > number of such clients, led to the belief that > these users should all be able to share a simple > built-in lock in the ida module by calling the > ida_simple_*() functions instead of the non-simple > versions. This means that ida does all the > required locking so that clients don't have to > manage that. The whole series looks good to me. Please feel free to add Reviewed-by: Tejun Heo Thanks. -- tejun