From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752503AbbJFHf0 (ORCPT ); Tue, 6 Oct 2015 03:35:26 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:53154 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbbJFHfZ (ORCPT ); Tue, 6 Oct 2015 03:35:25 -0400 Date: Tue, 6 Oct 2015 09:34:47 +0200 From: Francois Romieu To: Andrej Ota Cc: linux-kernel@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH] via-rhine: fix VLAN receive handling error in 4.2.x Message-ID: <20151006073447.GA10346@electric-eye.fr.zoreil.com> References: <20151003214708.GA32210@electric-eye.fr.zoreil.com> <20151004200603.380C4F4DA@mta2.toshio.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151004200603.380C4F4DA@mta2.toshio.eu> X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrej Ota : > Fixes commit 810f19bcb862 ("via-rhine: add consistent memory barrier in > vlan receive code.") which broke VLAN tag parsing on receive. > > Because eth_type_trans() consumes ethernet header worth of bytes, a call > to read TCI from packet using rhine_rx_vlan_tag() no longer works as it's > reading from an invalid offset. > > Tested to be working on PCEngines Alix board. > > Fixes: 810f19bcb862 ("via-rhine: add consistent memory barrier in vlan receive code.") > Signed-off-by: Andrej Ota Minor nits: - Ethernet driver patches should usually be sent to netdev@vger.kernel.org. Their state is thus tracked at http://patchwork.ozlabs.org/project/netdev/list/ - The more specific about the target branch, the better: [PATCH net 1/1] via-rhine: blah -> patch against davem's bugfixes branch [PATCH net-next 19/73] foo: more balh -> patch against davem's dev branch - davem will take care of -stable propagation -- Ueimor