From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728AbbJFLAR (ORCPT ); Tue, 6 Oct 2015 07:00:17 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46880 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbbJFLAP (ORCPT ); Tue, 6 Oct 2015 07:00:15 -0400 Date: Tue, 6 Oct 2015 11:59:07 +0100 From: Mark Brown To: Jiada Wang Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20151006105907.GM12635@sirena.org.uk> References: <1444115215-4388-1-git-send-email-jiada_wang@mentor.com> <1444115215-4388-2-git-send-email-jiada_wang@mentor.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5H9Hz1/zx6zDf/+6" Content-Disposition: inline In-Reply-To: <1444115215-4388-2-git-send-email-jiada_wang@mentor.com> X-Cookie: Walk softly and carry a megawatt laser. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 89.101.192.72 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] ASoC: WM8962: mark cache_dirty flag after software reset in pm_resume X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5H9Hz1/zx6zDf/+6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 06, 2015 at 04:06:54PM +0900, Jiada Wang wrote: > + /* All registers have been reset to default value without calling > + * to regmap interface, even if reset fails, some registers > + * maybe in intermediate status, so we need to mark regmap > + * cache_dirty flag. > + */ > + regcache_mark_dirty(wm8962->regmap); This is a standard thing that applies to almost all devices, there should be no need for such an extensive comment (which would normally flag up that there's something weird and surprising going on). --5H9Hz1/zx6zDf/+6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWE6l7AAoJECTWi3JdVIfQaK8H/3T/21Wzr7bprCo11JF9kEWl aVYmljhvX7tOUktTpaLvf+JW1ZsvF75fj+9OfISNcB+Emz+f6tFEFmOujt5Y91Wu KrEPqOrmQonPwaGosdtJbyeNa6USp6469dRGwOWQ6sghnp+2z/H2mfcXEut0tHgX A1PTgBW65O1HUUwcPSijPpzOoHd6rI1AIWrEHCY46Hp2CmAAAtO/cvz3rmXuv6++ uCL9hQuSqTZFwoIqedg9HvnmiHSc+KRC58Ktkn3RXR/jf4KnHpB8CrOJsYBDfmG0 4Iisb4eH7C7Rh06BW3GLISOYRkhz+8PnvNmUO/6jyJ5PYSejLI+sOaHtb30ugh0= =jMzS -----END PGP SIGNATURE----- --5H9Hz1/zx6zDf/+6--