From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752853AbbJFSR1 (ORCPT ); Tue, 6 Oct 2015 14:17:27 -0400 Received: from SMTP.ANDREW.CMU.EDU ([128.2.105.203]:48055 "EHLO smtp.andrew.cmu.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773AbbJFSRZ (ORCPT ); Tue, 6 Oct 2015 14:17:25 -0400 Date: Tue, 6 Oct 2015 14:17:03 -0400 From: "Gabriel L. Somlo" To: Andy Lutomirski Cc: Greg KH , paul@pwsan.com, galak@codeaurora.org, Will Deacon , agross@codeaurora.org, Mark Rutland , zajec5@gmail.com, hanjun.guo@linaro.org, Catalin Marinas , Linux API , "linux-kernel@vger.kernel.org" , kernelnewbies@kernelnewbies.org, Matt Fleming , Laszlo Ersek , "Jordan Justen (Intel address)" , "Michael S. Tsirkin" , peter.maydell@linaro.org, Leif Lindholm , Ard Biesheuvel , Paolo Bonzini , kraxel@redhat.com, "qemu-devel@nongnu.org Developers" Subject: Re: [PATCH v3 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device Message-ID: <20151006181703.GG1962@HEDWIG.INI.CMU.EDU> References: <1443914889-9619-1-git-send-email-somlo@cmu.edu> <1443914889-9619-2-git-send-email-somlo@cmu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.5.24 (2015-08-30) X-PMX-Version: 6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.10.6.180616 X-SMTP-Spam-Clean: 8% ( MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1300_1399 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, FROM_EDU_TLD 0, NO_URI_HTTPS 0, REFERENCES 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CT 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __HAS_FROM 0, __HAS_MSGID 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __URI_NO_PATH 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0) X-SMTP-Spam-Score: 8% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 06, 2015 at 10:54:42AM -0700, Andy Lutomirski wrote: > On Sat, Oct 3, 2015 at 4:28 PM, Gabriel L. Somlo wrote: > > From: Gabriel Somlo > > > > Make fw_cfg entries of type "file" available via sysfs. Entries > > are listed under /sys/firmware/qemu_fw_cfg/by_key, in folders > > named after each entry's selector key. Filename, selector value, > > and size read-only attributes are included for each entry. Also, > > a "raw" attribute allows retrieval of the full binary content of > > each entry. > > > > This patch also provides a documentation file outlining the > > guest-side "hardware" interface exposed by the QEMU fw_cfg device. > > > > What's the status of "by_name"? There's a single (presumably > incorrect) mention of it in a comment in this patch. > > I would prefer if the kernel populated by_name itself rather than > deferring that to udev, since I'd like to use this facility in virtme, > and I'd like to use fw_cfg very early on boot before I even start > udev. "by_name" is added with patch 4/4 of the series, which I kept separate due to the "To udev or not to udev" conversation from earlier. So far I haven't yet figured out just HOW I'd set it up in udev, but it works already if done in the kernel :) Thanks, --Gabriel