From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753388AbbJFT2u (ORCPT ); Tue, 6 Oct 2015 15:28:50 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:43557 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752914AbbJFT2s (ORCPT ); Tue, 6 Oct 2015 15:28:48 -0400 Date: Tue, 6 Oct 2015 20:28:36 +0100 From: Russell King - ARM Linux To: Chanho Min , nico@fluxnic.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jongsung Kim , Gunho Lee Subject: Re: [PATCH] ARM:mm: fix kmap_atomic_to_page Message-ID: <20151006192836.GX21513@n2100.arm.linux.org.uk> References: <1444129773-12632-1-git-send-email-chanho.min@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444129773-12632-1-git-send-email-chanho.min@lge.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 06, 2015 at 08:09:33PM +0900, Chanho Min wrote: > Since kmap_atomic returns the pkmap address without a new mapping to > fixmap for the page that is already mapped by kmap, It should be > considered for the pkmap address in kmap_atomic_to_page. What's the reasoning behind this change, given that I can find lots of definitions of kmap_atomic_to_page() in the kernel, but not a single user of this. If there's no users, should we be deleting this code? -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.