From: Mark Brown <broonie@kernel.org>
To: sugar <sugar.zhang@rock-chips.com>
Cc: alsa-devel@alsa-project.org, heiko@sntech.de,
linux-kernel@vger.kernel.org, tiwai@suse.com,
lgirdwood@gmail.com, linux-rockchip@lists.infradead.org,
perex@perex.cz, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support
Date: Wed, 7 Oct 2015 10:27:14 +0100 [thread overview]
Message-ID: <20151007092714.GZ12635@sirena.org.uk> (raw)
In-Reply-To: <5614D162.3020500@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Wed, Oct 07, 2015 at 04:01:38PM +0800, sugar wrote:
> 在 10/1/2015 02:46, Mark Brown 写道:
> >What makes you say that the symmetric_rates flag can't be used to cover
> >this case? What you describe above is hte normal reason for needing to
> >enforce symmetric_rates. The driver should be able to check if the flag
> >has been set just as well as the core is.
> Got it, How about the following modify?
> if (dai->symmetric_rates)
> regmap_update_bits(i2s->regmap, I2S_CKR,
> I2S_CKR_TRCM_MASK,
> I2S_CKR_TRCM(val));
Yes, something like that. You'll need to check both links in the DAI
and the DAI link itself rather than just your own DAI but we should have
a helper function for that - I'll add one, look out for a patch shortly.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-07 9:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 3:41 [PATCH 0/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode Sugar Zhang
2015-09-23 3:41 ` [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support Sugar Zhang
2015-09-23 16:24 ` Mark Brown
2015-09-28 8:16 ` sugar
2015-09-30 18:46 ` Mark Brown
2015-10-07 8:01 ` sugar
2015-10-07 9:27 ` Mark Brown [this message]
2015-10-07 9:39 ` Mark Brown
2015-10-07 10:01 ` sugar
2015-10-07 13:04 ` [alsa-devel] " Caleb Crome
2015-10-08 1:47 ` sugar
2015-10-08 2:36 ` Caleb Crome
2015-10-08 2:44 ` sugar
2015-10-08 3:19 ` Caleb Crome
2015-10-08 3:59 ` sugar
2015-09-23 3:41 ` [PATCH 2/2] Documentation: DT bindings: rockchip-i2s: add capture and lrck-mode Sugar Zhang
2015-09-23 16:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007092714.GZ12635@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=sugar.zhang@rock-chips.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®