From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: gregkh@linuxfoundation.org, stefan.wahren@i2se.com,
andrew@lunn.ch, s.hauer@pengutronix.de,
pantelis.antoniou@konsulko.com, linux-kernel@vger.kernel.org,
maitysanchayan@gmail.com, p.zabel@pengutronix.de,
maxime.ripard@free-electrons.com,
linux-arm-kernel@lists.infradead.org, wxt@rock-chips.com
Subject: Re: [PATCH v2 1/3] nvmem: core: make default user binary file root-access only
Date: Wed, 7 Oct 2015 12:33:49 +0100 [thread overview]
Message-ID: <20151007113349.GJ21513@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1444215647-10836-1-git-send-email-srinivas.kandagatla@linaro.org>
On Wed, Oct 07, 2015 at 12:00:47PM +0100, Srinivas Kandagatla wrote:
> As required by many providers like at24/at25/mxs-ocotp/qfprom and may be
> other providers would want to allow root-only to read the nvmem content.
> So making the defaults to be root-only access would address the request
> and also provide flexibility to providers to specify there own permissions
> on top of the root-only using the perm flag in nvmem_config.
> Making this dynamic did cut down lot of static binary attributes in the
> code.
Check what the lifetime of a struct bin_attribute is before you embed it
into any other structure. Sorry, but I think you're going to have to
read up on the driver model, sysfs, and kernfs implementations to find
out - I don't know the answer to this without doing the same.
However, this is basic checking that anyone should do when embedding
a structure within another.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-10-07 11:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 10:58 [PATCH v2 0/3] nvmem: make sysfs binary file permissions more flexible Srinivas Kandagatla
2015-10-07 11:00 ` [PATCH v2 1/3] nvmem: core: make default user binary file root-access only Srinivas Kandagatla
2015-10-07 11:33 ` Russell King - ARM Linux [this message]
2015-10-07 13:46 ` Srinivas Kandagatla
2015-10-07 16:23 ` Russell King - ARM Linux
2015-10-07 12:55 ` Greg KH
2015-10-07 13:18 ` Srinivas Kandagatla
2015-10-07 16:12 ` Greg KH
2015-10-07 11:00 ` [PATCH v2 2/3] nvmem: core: set the size for the nvmem binary file Srinivas Kandagatla
2015-10-07 12:56 ` Greg KH
2015-10-07 13:21 ` Srinivas Kandagatla
2015-10-07 11:01 ` [PATCH v2 3/3] nvmem: core: add sysfs file mode flag in nvmem_config Srinivas Kandagatla
2015-10-07 12:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007113349.GJ21513@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=andrew@lunn.ch \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=p.zabel@pengutronix.de \
--cc=pantelis.antoniou@konsulko.com \
--cc=s.hauer@pengutronix.de \
--cc=srinivas.kandagatla@linaro.org \
--cc=stefan.wahren@i2se.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®