From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753555AbbJGOB1 (ORCPT ); Wed, 7 Oct 2015 10:01:27 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:34313 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751357AbbJGOB0 (ORCPT ); Wed, 7 Oct 2015 10:01:26 -0400 Date: Wed, 7 Oct 2015 16:01:21 +0200 From: Sascha Hauer To: Mark Brown Cc: Arnd Bergmann , Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH] regulator: core: mark lock functions as __maybe_unused Message-ID: <20151007140121.GB7858@pengutronix.de> References: <6130994.OMIWUN9F6x@wuerfel> <20151007102407.GF12635@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151007102407.GF12635@sirena.org.uk> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 16:00:26 up 18 days, 3:29, 64 users, load average: 0.20, 0.18, 0.15 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2015 at 11:24:07AM +0100, Mark Brown wrote: > On Wed, Oct 07, 2015 at 12:12:09PM +0200, Arnd Bergmann wrote: > > > The best way to avoid these would be to add the code that will > > use these functions. If that still takes a while, this patch > > at least shuts up the compiler by marking the functions > > as __maybe_unused. The same could be achieved by marking them > > as static inline or non-static, or by hiding them from the > > compiler, but those seemed less appropriate. > > That code is still in review, it's not looking too hard to get merged. I'll send an update on that next week after ELCE. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |