From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751948AbbJGWou (ORCPT ); Wed, 7 Oct 2015 18:44:50 -0400 Received: from ozlabs.org ([103.22.144.67]:35063 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbbJGWos (ORCPT ); Wed, 7 Oct 2015 18:44:48 -0400 Date: Thu, 8 Oct 2015 09:44:44 +1100 From: Stephen Rothwell To: Linus Torvalds Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Metcalf , Subject: linux-next: build failure after merge of Linus' tree Message-ID: <20151008094444.10d9cc68@canb.auug.org.au> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, After merging Linus' tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: lib/string.c: In function 'strscpy': lib/string.c:209:4: error: implicit declaration of function 'zero_bytemask' [-Werror=implicit-function-declaration] *(unsigned long *)(dest+res) = c & zero_bytemask(data); ^ Caused by commit 30035e45753b ("string: provide strscpy()") but only exposed by commit 19c22f3a29fa ("word-at-a-time.h: fix some Kbuild files") BIG_ENDIAN powerpc doesn't have a definition for this function ... Isn't this why we have linux-next ... to find this stuff early? :-( Oh, well, I have applied the following (that just copies zero_bytemask from asm-generic. I have done no testing beyond compiling. From: Stephen Rothwell Date: Thu, 8 Oct 2015 09:29:26 +1100 Subject: [PATCH] word-at-a-time.h: powerpc: implement define zero_bytemask Signed-off-by: Stephen Rothwell --- arch/powerpc/include/asm/word-at-a-time.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/include/asm/word-at-a-time.h b/arch/powerpc/include/asm/word-at-a-time.h index 5b3a903adae6..4f9b6b93c18f 100644 --- a/arch/powerpc/include/asm/word-at-a-time.h +++ b/arch/powerpc/include/asm/word-at-a-time.h @@ -40,6 +40,8 @@ static inline bool has_zero(unsigned long val, unsigned long *data, const struct return (val + c->high_bits) & ~rhs; } +#define zero_bytemask(mask) (~1ul << __fls(mask)) + #else #ifdef CONFIG_64BIT -- 2.5.1 -- Cheers, Stephen Rothwell sfr@canb.auug.org.au