From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754038AbbJHKPQ (ORCPT ); Thu, 8 Oct 2015 06:15:16 -0400 Received: from foss.arm.com ([217.140.101.70]:33466 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796AbbJHKPO (ORCPT ); Thu, 8 Oct 2015 06:15:14 -0400 Date: Thu, 8 Oct 2015 11:15:09 +0100 From: Catalin Marinas To: "Suzuki K. Poulose" Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, Vladimir.Murzin@arm.com, steve.capper@linaro.org, ard.biesheuvel@linaro.org, marc.zyngier@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, edward.nevill@linaro.org, aph@redhat.com, james.morse@arm.com, andre.przywara@arm.com, dave.martin@arm.com Subject: Re: [PATCH v2 11/22] arm64: Populate cpuinfo after notify_cpu_starting Message-ID: <20151008101508.GE17192@e104818-lin.cambridge.arm.com> References: <1444064531-25607-1-git-send-email-suzuki.poulose@arm.com> <1444064531-25607-12-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444064531-25607-12-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2015 at 06:02:00PM +0100, Suzuki K. Poulose wrote: > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index cb3e0d8..6987de4 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -163,14 +163,14 @@ asmlinkage void secondary_start_kernel(void) > cpu_ops[cpu]->cpu_postboot(); > > /* > - * Log the CPU info before it is marked online and might get read. > + * Enable GIC and timers. > */ > - cpuinfo_store_cpu(); > + notify_cpu_starting(cpu); > > /* > - * Enable GIC and timers. > + * Log the CPU info before it is marked online and might get read. > */ > - notify_cpu_starting(cpu); > + cpuinfo_store_cpu(); > > smp_store_cpu_info(cpu); You can move the cpuinfo_store_cpu() call directly to smp_store_cpu_info(). -- Catalin