From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755675AbbJHLRZ (ORCPT ); Thu, 8 Oct 2015 07:17:25 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:47714 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755168AbbJHLRW (ORCPT ); Thu, 8 Oct 2015 07:17:22 -0400 Date: Thu, 8 Oct 2015 12:17:09 +0100 From: Russell King - ARM Linux To: Catalin Marinas Cc: "Suzuki K. Poulose" , mark.rutland@arm.com, Vladimir.Murzin@arm.com, steve.capper@linaro.org, ard.biesheuvel@linaro.org, marc.zyngier@arm.com, andre.przywara@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, edward.nevill@linaro.org, aph@redhat.com, james.morse@arm.com, dave.martin@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 14/22] arm64: Cleanup HWCAP handling Message-ID: <20151008111709.GE32532@n2100.arm.linux.org.uk> References: <1444064531-25607-1-git-send-email-suzuki.poulose@arm.com> <1444064531-25607-15-git-send-email-suzuki.poulose@arm.com> <20151008111000.GG17192@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151008111000.GG17192@e104818-lin.cambridge.arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2015 at 12:10:00PM +0100, Catalin Marinas wrote: > On Mon, Oct 05, 2015 at 06:02:03PM +0100, Suzuki K. Poulose wrote: > > +static bool cpus_have_hwcap(const struct arm64_cpu_capabilities *cap) > > +{ > > + switch(cap->hwcap_type) { > > + case CAP_HWCAP: > > + return !!(elf_hwcap & cap->hwcap); > > +#ifdef CONFIG_COMPAT > > + case CAP_COMPAT_HWCAP: > > + return !!(compat_elf_hwcap & (u32)cap->hwcap); > > + case CAP_COMPAT_HWCAP2: > > + return !!(compat_elf_hwcap2 & (u32)cap->hwcap); > > +#endif > > + default: > > + BUG(); > > + return false; > > + } > > +} > > Apart from the multiple returns, you don't really need !! since the > return type is bool already. That's wrong. a & b doesn't return 0 or 1, but the bitwise-and result. http://yarchive.net/comp/linux/bool.html especially hpa's response. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.