From: Andrew Morton <akpm@linux-foundation.org>
To: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] slab_common: clear pointers to per memcg caches on destroy
Date: Thu, 8 Oct 2015 14:17:35 -0700 [thread overview]
Message-ID: <20151008141735.d545d3fa1ab0244f69c41cdf@linux-foundation.org> (raw)
In-Reply-To: <833ae913932949814d1063e11248e6747d0c3a2b.1444319304.git.vdavydov@virtuozzo.com>
On Thu, 8 Oct 2015 19:02:40 +0300 Vladimir Davydov <vdavydov@virtuozzo.com> wrote:
> Currently, we do not clear pointers to per memcg caches in the
> memcg_params.memcg_caches array when a global cache is destroyed with
> kmem_cache_destroy. It is fine if the global cache does get destroyed.
> However, a cache can be left on the list if it still has active objects
> when kmem_cache_destroy is called (due to a memory leak). If this
> happens, the entries in the array will point to already freed areas,
> which is likely to result in data corruption when the cache is reused
> (via slab merging).
It's important that we report these leaks so the kernel bug can get
fixed. The patch doesn't add such detection and reporting, but it
could do so?
next prev parent reply other threads:[~2015-10-08 21:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 16:02 [PATCH 1/3] slab_common: rename cache create/destroy helpers Vladimir Davydov
2015-10-08 16:02 ` [PATCH 2/3] slab_common: clear pointers to per memcg caches on destroy Vladimir Davydov
2015-10-08 21:17 ` Andrew Morton [this message]
2015-10-09 8:08 ` Vladimir Davydov
2015-10-08 16:02 ` [PATCH 3/3] slab_common: do not warn that cache is busy on destroy more than once Vladimir Davydov
2015-10-08 16:54 ` [PATCH 1/3] slab_common: rename cache create/destroy helpers Christoph Lameter
2015-10-14 2:35 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008141735.d545d3fa1ab0244f69c41cdf@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome